* [PATCH] mmc: sdhci: dove: Fix build breakage
@ 2013-10-23 13:10 Thierry Reding
2013-10-23 13:45 ` Jeremie Samuel
2013-10-27 12:56 ` Chris Ball
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2013-10-23 13:10 UTC (permalink / raw)
To: Chris Ball; +Cc: linux-mmc, linux-kernel
Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
converts tasklets to work structs, but typos the conversion in the Dove
driver.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/mmc/host/sdhci-dove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
index 45c7f25..95f1076 100644
--- a/drivers/mmc/host/sdhci-dove.c
+++ b/drivers/mmc/host/sdhci-dove.c
@@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
{
struct sdhci_host *host = data;
- schedule_schedule(&host->card_detect_work);
+ schedule_work(&host->card_detect_work);
return IRQ_HANDLED;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sdhci: dove: Fix build breakage
2013-10-23 13:10 [PATCH] mmc: sdhci: dove: Fix build breakage Thierry Reding
@ 2013-10-23 13:45 ` Jeremie Samuel
2013-10-27 12:56 ` Chris Ball
1 sibling, 0 replies; 4+ messages in thread
From: Jeremie Samuel @ 2013-10-23 13:45 UTC (permalink / raw)
To: Thierry Reding; +Cc: Chris Ball, linux-mmc, linux-kernel
Soory, I thought I had corrected this typo.
Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com>
--
Jeremie Samuel Parrot S.A.
Software Engineer 14, quai de Jemmapes
R&D/OS Platform 75010 Paris, France
http://www.parrot.com
On 23/10/2013 15:10, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mmc/host/sdhci-dove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> {
> struct sdhci_host *host = data;
>
> - schedule_schedule(&host->card_detect_work);
> + schedule_work(&host->card_detect_work);
> return IRQ_HANDLED;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sdhci: dove: Fix build breakage
2013-10-23 13:10 [PATCH] mmc: sdhci: dove: Fix build breakage Thierry Reding
2013-10-23 13:45 ` Jeremie Samuel
@ 2013-10-27 12:56 ` Chris Ball
2013-10-28 7:47 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Chris Ball @ 2013-10-27 12:56 UTC (permalink / raw)
To: Thierry Reding, Jeremie Samuel; +Cc: linux-mmc, linux-kernel
Hi,
On Wed, Oct 23 2013, Thierry Reding wrote:
> Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> converts tasklets to work structs, but typos the conversion in the Dove
> driver.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/mmc/host/sdhci-dove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> index 45c7f25..95f1076 100644
> --- a/drivers/mmc/host/sdhci-dove.c
> +++ b/drivers/mmc/host/sdhci-dove.c
> @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> {
> struct sdhci_host *host = data;
>
> - schedule_schedule(&host->card_detect_work);
> + schedule_work(&host->card_detect_work);
> return IRQ_HANDLED;
> }
Thanks, Thierry -- I hope it's okay with you if I merge your fix into
the original patch and add your S-o-b to that patch:
Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com>
[treding: Fix typo causing sdhci-dove build breakage]
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: sdhci: dove: Fix build breakage
2013-10-27 12:56 ` Chris Ball
@ 2013-10-28 7:47 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2013-10-28 7:47 UTC (permalink / raw)
To: Chris Ball; +Cc: Jeremie Samuel, linux-mmc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
On Sun, Oct 27, 2013 at 08:56:55AM -0400, Chris Ball wrote:
> Hi,
>
> On Wed, Oct 23 2013, Thierry Reding wrote:
> > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> > converts tasklets to work structs, but typos the conversion in the Dove
> > driver.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/mmc/host/sdhci-dove.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> > index 45c7f25..95f1076 100644
> > --- a/drivers/mmc/host/sdhci-dove.c
> > +++ b/drivers/mmc/host/sdhci-dove.c
> > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> > {
> > struct sdhci_host *host = data;
> >
> > - schedule_schedule(&host->card_detect_work);
> > + schedule_work(&host->card_detect_work);
> > return IRQ_HANDLED;
> > }
>
> Thanks, Thierry -- I hope it's okay with you if I merge your fix into
> the original patch and add your S-o-b to that patch:
>
> Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
> Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@parrot.com>
> [treding: Fix typo causing sdhci-dove build breakage]
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Chris Ball <cjb@laptop.org>
Sure, no problem.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-28 7:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-23 13:10 [PATCH] mmc: sdhci: dove: Fix build breakage Thierry Reding
2013-10-23 13:45 ` Jeremie Samuel
2013-10-27 12:56 ` Chris Ball
2013-10-28 7:47 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).