From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux@prisktech.co.nz
Cc: linux-mmc@vger.kernel.org
Subject: re: mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650
Date: Fri, 8 Nov 2013 13:03:50 +0300 [thread overview]
Message-ID: <20131108100350.GS27977@elgon.mountain> (raw)
Hello Tony Prisk,
This is a semi-automatic email about new static checker warnings.
The patch 3a96dff0f828: "mmc: SD/MMC Host Controller for Wondermedia
WM8505/WM8650" from Nov 18, 2012, leads to the following Smatch
complaint:
drivers/mmc/host/wmt-sdmmc.c:764 wmt_mci_probe()
warn: variable dereferenced before check 'of_id' (see line 760)
drivers/mmc/host/wmt-sdmmc.c
759 of_match_device(wmt_mci_dt_ids, &pdev->dev);
760 const struct wmt_mci_caps *wmt_caps = of_id->data;
^^^^^^^^^^^
Dereference.
761 int ret;
762 int regular_irq, dma_irq;
763
764 if (!of_id || !of_id->data) {
^^^^^
Check.
765 dev_err(&pdev->dev, "Controller capabilities data missing\n");
766 return -EFAULT;
regards,
dan carpenter
reply other threads:[~2013-11-08 10:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108100350.GS27977@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@prisktech.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox