From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path Date: Wed, 4 Dec 2013 10:00:41 -0800 Message-ID: <20131204180041.GS26766@atomide.com> References: <20131202193459.GL26766@atomide.com> <529E201B.6030306@bitmer.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:23704 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788Ab3LDSAp (ORCPT ); Wed, 4 Dec 2013 13:00:45 -0500 Content-Disposition: inline In-Reply-To: <529E201B.6030306@bitmer.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jarkko Nikula Cc: Chris Ball , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, Dan Carpenter , Aaro Koskinen , Jarkko Lavinen * Jarkko Nikula [131203 08:18]: > On 12/02/2013 07:34 PM, Tony Lindgren wrote: > > Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely > > on device id) fixed getting of the DMA resources when booted with > > device tree. This patch however changed the handling of the > > free_mem_region() error path by reusing the struct resource *res > > for the DMA resources. > > > > Fix the error the same way omap_hsmmc.c driver handles it, which > > is to restore the resource before using the values to call > > release_mem_region(). > > > > Reported-by: Dan Carpenter > > Signed-off-by: Tony Lindgren > > > I guess my devm_ioremap conversion would have fixed this? > > http://www.spinics.net/lists/linux-mmc/msg23317.html Probably.. > Does not help now but I'm thinking if queuing some of those my patches > (3-5) on top of yours as a fix? Especially fix to NULL pointer dereference: > > http://www.spinics.net/lists/linux-mmc/msg23320.html Yeah please do, how about also adding the error log to the description? Regards, Tony