From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?iso-8859-15?q?St=FCbner?= Subject: Re: [PATCH 2/2] mmc: dw_mmc-pltm: Remove Rockchip's custom dw_mmc driver structure Date: Sat, 7 Dec 2013 00:22:03 +0100 Message-ID: <201312070022.03414.heiko@sntech.de> References: <1386346223-18464-1-git-send-email-dinguyen@altera.com> <201312070014.53895.heiko@sntech.de> <52A25B2F.60209@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from gloria.sntech.de ([95.129.55.99]:41554 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759745Ab3LFXWM (ORCPT ); Fri, 6 Dec 2013 18:22:12 -0500 In-Reply-To: <52A25B2F.60209@gmail.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Dinh Nguyen Cc: dinguyen@altera.com, arnd@arndb.de, cjb@laptop.org, jh80.chung@samsung.com, tgih.jun@samsung.com, dianders@chromium.org, alim.akhtar@samsung.com, bzhao@marvell.com, linux-mmc@vger.kernel.org Am Samstag, 7. Dezember 2013, 00:18:07 schrieb Dinh Nguyen: > On 12/6/13 5:14 PM, Heiko St=FCbner wrote: > > Am Freitag, 6. Dezember 2013, 17:10:23 schrieb dinguyen@altera.com: > >> From: Dinh Nguyen > >>=20 > >> Rockchip's implementation of the dw_mmc controller only requires t= he > >> setting of the SDMMC_CMD_USE_HOLD_REG on every command. With the p= atch > >> to set the SDMMC_CMD_USE_HOLD_REG by checking the slot's speed mod= e, > >> this Rockchip custom driver structure is no longer necessary. > >>=20 > >> Signed-off-by: Dinh Nguyen > >=20 > > hmm, testing will need a bit more time, as it seems one of the chan= ges > > merged during the 3.13 merge window broke the dw-mmc on the rockchi= p. >=20 > Thanks Heiko. Don't bother with v1, I overlooked another aspect of us= ing > the hold > reg. Let me send out a v2 for you to test. Don't worry ... as I've said, first I need to find the current issue :-= ) Heiko