Re: Re: [PATCH 1/5] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

Maxime Ripard
2013-12-16T10:05:51Z

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

On Sun, Dec 15, 2013 at 11:01:17PM +0100, Michal Suchanek wrote:
> On 15 December 2013 14:44, Maxime Ripard
> <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> >> --- a/drivers/mmc/host/Kconfig
> >> +++ b/drivers/mmc/host/Kconfig
> >> @@ -665,3 +665,11 @@ config MMC_REALTEK_PCI
> >> help
> >> Say Y here to include driver code to support SD/MMC card interface
> >> of Realtek PCI-E card reader
> >> +
> >> +config MMC_SUNXI
> >> + tristate "Allwinner sunxi SD/MMC Host Controller support"
> >> + depends on ARCH_SUNXI
> >> + default y
> >
> > I'm not that fond of these "default y" patterns. It forces the driver
> > down to every user of the multiplatform kernels. I'd suggest removing
> > the default and adding the driver to the defconfigs we have.
>
> And why would you build support for sunxi without building support for
> sunxi mmc?

Because you can?

And where am I actually suggesting to do so?

> Like 90%+ sunxi devices actually have a SD slot or an eMMC or a SDIO
> card connected so what's the point of supporting sunxi without sunxi
> mmc?

And does your assumption still stand if you take into account all the
other ARM boards?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]