From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH 1/1] mmc: sdhci: fix lockdep error on tunning routine Date: Wed, 15 Jan 2014 08:46:53 +0100 Message-ID: <20140115084653.4f6aece8@ipc1.ka-ro> References: <1387797184-18958-1-git-send-email-b29396@freescale.com> <20140113120435.GQ31570@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.karo-electronics.de ([81.173.242.67]:63183 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbaAOHry convert rfc822-to-8bit (ORCPT ); Wed, 15 Jan 2014 02:47:54 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Dong Aisheng Cc: Peter Zijlstra , Chris Ball , Sascha Hauer , "linux-mmc@vger.kernel.org" , Shawn Guo , Dong Aisheng , "linux-arm-kernel@lists.infradead.org" Hi, Dong Aisheng wrote: > On Mon, Jan 13, 2014 at 8:04 PM, Peter Zijlstra wrote: > > On Thu, Dec 26, 2013 at 03:58:20PM +0800, Dong Aisheng wrote: > >> > It's strange that this issue did not happen on kernel 3.10.17 wi= th the same > >> > code. And looking at the code, before call spin_lock we already = disable the mmc > >> > controller irq, per on my understanding, the deadlock given by l= ockdep may not > >> > be able to happen(pls fix me if wrong). > >> > May the lockdep not track the specific irq disable? > >> > Copy lockdep guy to comment. > > > > No, lockdep also doesn't know only that one line can take this lock= =2E > > Lockdep only knows a lock is taken from IRQ context, and disabling = one > > line still allows IRQs to happen and therefore it yells. >=20 > Okay, thanks for the information. > If that, kernel 3.10.17 has the same code, do you know why it does no= t trigger > such lockdep error? >=20 compiled with CONFIG_LOCKDEP disabled? Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________