Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

From: Lee Jones <lee.jones@linaro.org>
To: Roger <rogerable@realtek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Maxim Levitsky <maximlevitsky@gmail.com>,
	Alex Dubov <oakad@yahoo.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
	linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver
Date: Mon, 17 Feb 2014 12:03:26 +0000	[thread overview]
Message-ID: <20140217120326.GC20218@lee--X1> (raw)
In-Reply-To: <5301E376.8010000@realtek.com>

> >>>>>>From: Roger Tseng <rogerable@realtek.com>
> >>>>>>
> >>>>>>Realtek USB card reader provides a channel to transfer command or data to flash
> >>>>>>memory cards. This driver exports host instances for mmc and memstick subsystems
> >>>>>>and handles basic works.
> >>>>>>
> >>>>>>Signed-off-by: Roger Tseng <rogerable@realtek.com>
> >>>>>>---
> >>>>>>  drivers/mfd/Kconfig          |  10 +
> >>>>>>  drivers/mfd/Makefile         |   1 +
> >>>>>>  drivers/mfd/rtsx_usb.c       | 760 +++++++++++++++++++++++++++++++++++++++++++
> >>>>>>  include/linux/mfd/rtsx_usb.h | 628 +++++++++++++++++++++++++++++++++++
> >>>>>>  4 files changed, 1399 insertions(+)
> >>>>>>  create mode 100644 drivers/mfd/rtsx_usb.c
> >>>>>>  create mode 100644 include/linux/mfd/rtsx_usb.h
> >>>>>
> >>>>>Applied again, thanks.
> >>>>>
> >>>>Would you also apply patch 2/3 and 3/3 that to make the device fully
> >>>>operational for users? Or should they be applied by maintainers of
> >>>>mmc/memstick subsystems?
> >>>>
> >>>>Chris, would you give some comment?
> >>>
> >>>I can apply them, but I need the other Maintainer Acks.
> >>>
> >>>If they are build orthogonal i.e. there are no build dependencies
> >>>between them, it's probably better that they go into their associated
> >>>trees separately.
> >>>
> >>I think it would be better to apply them together since the later
> >>patches really depend on the 1st one,so now we are waiting for Acks
> >>from mmc/memstick subsystems.
> >
> >When you say "depend on", do you mean as a build depenency, or won't
> >run without the first patch applied?
> 
> The later 2 patches actually invoke symbols defined in the first
> patch and won't compile if it is not applied first. The Kconfig
> changes for the later oness also specified this by "depends on".
> 
> I'm not sure if this means "build dependency". Sorry for my unclear words.

Yes, that sounds like a build dependency i.e. will not build without
errors or warnings without the previous patch applied.

> >>But there is no one specified for "memstick/host/" in MAINTAINERS.
> >>Could anyone else Ack this?

Andrew (CC'ed) has been Acking these thus far.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel