From: Dan Carpenter <dan.carpenter@oracle.com>
To: micky_ching@realsil.com.cn
Cc: linux-mmc@vger.kernel.org
Subject: re: mmc: rtsx: add support for pre_req and post_req
Date: Tue, 25 Feb 2014 01:03:59 +0300 [thread overview]
Message-ID: <20140224220359.GB29170@elgon.mountain> (raw)
Hello Micky Ching,
This is a semi-automatic email about new static checker warnings.
The patch c42deffd5b53: "mmc: rtsx: add support for pre_req and
post_req" from Feb 17, 2014, leads to the following Smatch complaint:
drivers/mmc/host/rtsx_pci_sdmmc.c:504 sd_get_rsp()
error: we previously assumed 'cmd' could be null (see line 434)
drivers/mmc/host/rtsx_pci_sdmmc.c
433
434 if (!cmd) {
^^^
Patch introduces check.
435 dev_err(sdmmc_dev(host), "error: cmd not exist\n");
436 goto out;
437 }
438
[ snip ]
497 if (cmd->data) {
498 sd_start_multi_rw(host, host->mrq);
499 spin_unlock_irqrestore(&host->lock, flags);
500 return;
501 }
502
503 out:
504 cmd->error = err;
^^^^^^^^^^
Dereference was already there.
505
506 tasklet_schedule(&host->finish_tasklet);
regards,
dan carpenter
next reply other threads:[~2014-02-24 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 22:03 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-28 20:35 mmc: rtsx: add support for pre_req and post_req Dan Carpenter
2014-03-03 1:13 ` micky
2014-02-24 22:03 Dan Carpenter
2014-02-25 1:52 ` micky
2014-02-25 7:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224220359.GB29170@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-mmc@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox