linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Felipe Balbi <balbi@ti.com>, Balaji T K <balajitk@ti.com>,
	Daniel Mack <zonque@gmail.com>, Kumar Gala <galak@codeaurora.org>,
	linux-doc@vger.kernel.org, linux-mmc <linux-mmc@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v7 1/4] mmc: omap_hsmmc: Enable SDIO IRQ.
Date: Tue, 11 Mar 2014 09:37:54 -0700	[thread overview]
Message-ID: <20140311163753.GC7177@atomide.com> (raw)
In-Reply-To: <CALtMJEAv36qubJbNKZnnQPktP5UYYcxKc4e_K51AhQw6qePqjQ@mail.gmail.com>

* Andreas Fenkart <afenkart@gmail.com> [140311 02:45]:
> Hi,
> 
> 2014-03-05 17:33 GMT+01:00 Tony Lindgren <tony@atomide.com>:
> > * Andreas Fenkart <afenkart@gmail.com> [140305 00:30]:
> >> Hi,
> >>
> >> 2014-02-27 22:33 GMT+01:00 Tony Lindgren <tony@atomide.com>:
> >> >
> >> > The wake-irq is needed for omaps with wake-up path and also
> >> > when doing GPIO remuxing. So the wake-up handling is pretty
> >> > much the same for both cases.
> >> I added this comment to the patch, since I was puzzled that you need
> >> a wake_irq even whithout remuxing.
> >
> > Yeah we need it because omap_hsmmc is already doing runtime PM,
> > so there's nothing stopping from shutting it down. And there's
> > really no need to block runtime PM for it as it's working.
> >
> Also added this comment, since it really clarifies the issue.

OK thanks.
 
> FYI, just tried the patch without pin remuxing on am335x and
> it actually works. Read: I'm always using the sdio pinmux never
> reconfiguring the pin as a GPIO, but still get GPIO interrupts.
> Yes, it fails if I comment out the pm_runtime_resume.
> 
> So it's not that the am335x suddenly has a swakeup line,
> but looks like an implementation detail of the am335x GPIO
> block.

Oh OK, that's good to know. I think 2420 behaved that way too
for the serial wake-up. What also may affect things is if that
GPIO line is in the first GPIO bank, for the other banks
remuxing may still be needed for deeper idle states.

Regards,

Tony

  reply	other threads:[~2014-03-11 16:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 12:37 [PATCH v7 0/4] mmc: omap_hsmmc: SDIO IRQ Andreas Fenkart
2014-02-25 12:37 ` [PATCH v7 1/4] mmc: omap_hsmmc: Enable " Andreas Fenkart
2014-02-27 21:33   ` Tony Lindgren
2014-03-05  8:27     ` Andreas Fenkart
2014-03-05 16:33       ` Tony Lindgren
2014-03-11  9:42         ` Andreas Fenkart
2014-03-11 16:37           ` Tony Lindgren [this message]
2014-02-28 17:04   ` Balaji T K
2014-03-05  8:30     ` Andreas Fenkart
2014-03-07 15:12       ` Balaji T K
2014-03-07 16:04         ` Tony Lindgren
2014-02-25 12:37 ` [PATCH v7 2/4] mmc: omap_hsmmc: Remux SDIO pins within driver Andreas Fenkart
2014-02-27 21:36   ` Tony Lindgren
2014-02-27 21:42     ` Tony Lindgren
2014-02-25 12:37 ` [PATCH v7 3/4] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x Andreas Fenkart
2014-02-25 12:49   ` [PATCH v7 4/4] mmc: omap_hsmmc: Extend debugfs for SDIO IRQ, GPIO and pinmux Andreas Fenkart
2014-02-27 21:39     ` Tony Lindgren
2014-02-27 21:37   ` [PATCH v7 3/4] mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311163753.GC7177@atomide.com \
    --to=tony@atomide.com \
    --cc=afenkart@gmail.com \
    --cc=balajitk@ti.com \
    --cc=balbi@ti.com \
    --cc=cjb@laptop.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).