Re: [PATCH v8 11/17] ARM: dts: sun6i: Add mmc controller nodes

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

On Tue, Apr 22, 2014 at 01:01:31PM +0200, Hans de Goede wrote:
> Add nodes for the 4 mmc controllers found on A31 SoCs to
> arch/arm/boot/dts/sun6i-a31.dtsi.
> 
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  arch/arm/boot/dts/sun6i-a31.dtsi | 52 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
> index 12bcc17..a27afc8 100644
> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> @@ -269,6 +269,58 @@
>  		#size-cells = <1>;
>  		ranges;
>  
> +		mmc0: mmc@01c0f000 {
> +			compatible = "allwinner,sun5i-a13-mmc";
> +			reg = <0x01c0f000 0x1000>;
> +			clocks = <&ahb1_gates 8>, <&mmc0_clk>;
> +			clock-names = "ahb", "mod";
> +			resets = <&ahb1_rst 8>;
> +			reset-names = "ahb";
> +			interrupts = <0 60 4>;
> +			bus-width = <4>;
> +			cd-inverted;

The two last items should be in the DTS.

Looks good otherwise.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]