linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: ulf.hansson@linaro.org, sameo@linux.intel.com,
	gregkh@linuxfoundation.org, linux-mmc@vger.kernel.org,
	chris@printf.net, linux-kernel@vger.kernel.org,
	wei_wang@realsil.com.cn, devel@linuxdriverproject.org,
	rogerable@realtek.com
Subject: Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"
Date: Mon, 28 Apr 2014 14:59:47 +0300	[thread overview]
Message-ID: <20140428115947.GA28139@mwanda> (raw)
In-Reply-To: <20140428105350.GM21279@lee--X1>

On Mon, Apr 28, 2014 at 11:53:50AM +0100, Lee Jones wrote:
> > From: Micky Ching <micky_ching@realsil.com.cn>
> > 
> > This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
> 
> Why was this patch even merged without an MFD Ack?

I think process questions like this are very important.

These patches touch both mmc and mfd but they're mostly mmc patches.

They were first sent to LKML in January.  Samuel was on the CC list but
you were left off.  There were no replies to the thread.  The patches
were then resent in February and Micky complained that they had been
sent "many times" and no one was responding.  So then Chris took them.

You should have been included on the CC list and Chris should have asked
you or Sam for a response explicitly instead of waiting for a month and
giving up.

Also Micky, please, when you do a new version of a patch please put an
explanation of what changed between version 3 and version 4.
http://kernelnewbies.org/PatchTipsAndTricks

regards,
dan carpenter

      parent reply	other threads:[~2014-04-28 11:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28  7:36 [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" micky_ching
2014-04-28  7:42 ` [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqand post_req" micky
2014-04-28 10:40 ` [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" Ulf Hansson
2014-04-28 10:53 ` Lee Jones
2014-04-28 10:58   ` Ulf Hansson
2014-04-28 12:29     ` Lee Jones
2014-04-28 14:11       ` Ulf Hansson
2014-04-28 11:59   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140428115947.GA28139@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=chris@printf.net \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rogerable@realtek.com \
    --cc=sameo@linux.intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).