Re: [PATCH 0/2] mmc: rtsx: revert support for mmc async request

Lee Jones
2014-04-29T08:02:47Z

> From: Micky Ching <micky_ching@realsil.com.cn>
>
> The commit <mmc: rtsx: add support for pre_req and post_req> have some problem,
> using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
> these problem, and better to use a new method. So just remove it.
>
> The commit <mmc: rtsx: modify error handle and remove smatch warnings> depends
> on the previous patch. And mainly fix some problem for the previous patch. So
> need remove.
>
> Micky Ching (2):
> mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch
> warnings"
> mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"
>
> drivers/mfd/rtsx_pcr.c | 132 ++++-------
> drivers/mmc/host/rtsx_pci_sdmmc.c | 459 +++++++------------------------------
> include/linux/mfd/rtsx_common.h | 1 -
> include/linux/mfd/rtsx_pci.h | 6 -
> 4 files changed, 124 insertions(+), 474 deletions(-)

Just to clarify, what commit did you base these changes on? Have you
tested to ensure everything works as it should with these two
reversions?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog