* Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' [not found] <537de770.ItHqmb5BpaXWIlXq%fengguang.wu@intel.com> @ 2014-05-22 12:39 ` Ulf Hansson 2014-05-22 12:41 ` Chris Ball 0 siblings, 1 reply; 5+ messages in thread From: Ulf Hansson @ 2014-05-22 12:39 UTC (permalink / raw) To: Chris Ball; +Cc: Andreas Fenkart, linux-mmc, Tony Lindgren, balajitk On 22 May 2014 14:02, kbuild test robot <fengguang.wu@intel.com> wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next > head: 830bb78ad0985cc44246fcd6f6c1fdddd04c5abb > commit: f6a903a75eff1eb6d53703543b1674da211b0b28 [79/96] mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state > config: make ARCH=m68k allmodconfig > > All error/warnings: > > drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_regs_show': >>> drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' > > vim +1841 drivers/mmc/host/omap_hsmmc.c > > 1835 if (mmc->caps & MMC_CAP_SDIO_IRQ) { > 1836 seq_printf(s, "sdio irq \t%s\n", > 1837 (host->flags & HSMMC_SDIO_IRQ_ENABLED) ? "enabled" > 1838 : "disabled"); > 1839 } > 1840 >> 1841 suspended = host->dev->power.runtime_status != RPM_ACTIVE; > 1842 seq_printf(s, "runtime state\t%s\n", (suspended ? "idle" : "active")); > 1843 > 1844 seq_printf(s, "ctx_loss:\t%d\n", host->context_loss); > > --- > 0-DAY kernel build testing backend Open Source Technology Center > http://lists.01.org/mailman/listinfo/kbuild Intel Corporation Hi Chris, I had a second look at Andreas Fenkart's patchset to enable SDIO irq for omap. Those needs an additional iteration, since there are unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other Kconfigs as well). Apparently I had all the needed Kconfigs enabled while I compile tested them. :-( I tried out doing a local re-base, to remove the related omap patches. If you remove the patches below you won't get any conflicts for omap_hsmmc. Can you do that? Andreas: mmc: omap_hsmmc: Enable SDIO interrupt mmc: omap_hsmmc: enable wakeup event for sdio OMAP4 mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x Balaji: mmc: omap_hsmmc: use IS_ERR macro for error checking Kind regards Uffe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' 2014-05-22 12:39 ` [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' Ulf Hansson @ 2014-05-22 12:41 ` Chris Ball 2014-05-22 14:24 ` Tony Lindgren 0 siblings, 1 reply; 5+ messages in thread From: Chris Ball @ 2014-05-22 12:41 UTC (permalink / raw) To: Ulf Hansson; +Cc: Andreas Fenkart, linux-mmc, Tony Lindgren, balajitk Hi, On Thu, May 22 2014, Ulf Hansson wrote: > I had a second look at Andreas Fenkart's patchset to enable SDIO irq > for omap. Those needs an additional iteration, since there are > unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other > Kconfigs as well). Apparently I had all the needed Kconfigs enabled > while I compile tested them. :-( > > I tried out doing a local re-base, to remove the related omap patches. > If you remove the patches below you won't get any conflicts for > omap_hsmmc. Can you do that? > > Andreas: > mmc: omap_hsmmc: Enable SDIO interrupt > mmc: omap_hsmmc: enable wakeup event for sdio OMAP4 > mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state > mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected > mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks > mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x > > Balaji: > mmc: omap_hsmmc: use IS_ERR macro for error checking Done. Thanks! - Chris. -- Chris Ball <http://printf.net/> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' 2014-05-22 12:41 ` Chris Ball @ 2014-05-22 14:24 ` Tony Lindgren 2014-05-23 8:19 ` Andreas Fenkart 0 siblings, 1 reply; 5+ messages in thread From: Tony Lindgren @ 2014-05-22 14:24 UTC (permalink / raw) To: Chris Ball; +Cc: Ulf Hansson, Andreas Fenkart, linux-mmc, balajitk * Chris Ball <chris@printf.net> [140522 05:42]: > Hi, > > On Thu, May 22 2014, Ulf Hansson wrote: > > I had a second look at Andreas Fenkart's patchset to enable SDIO irq > > for omap. Those needs an additional iteration, since there are > > unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other > > Kconfigs as well). Apparently I had all the needed Kconfigs enabled > > while I compile tested them. :-( Did you find this out with make randconfig? > > I tried out doing a local re-base, to remove the related omap patches. > > If you remove the patches below you won't get any conflicts for > > omap_hsmmc. Can you do that? > > > > Andreas: > > mmc: omap_hsmmc: Enable SDIO interrupt > > mmc: omap_hsmmc: enable wakeup event for sdio OMAP4 > > mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state > > mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected > > mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks > > mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x > > > > Balaji: > > mmc: omap_hsmmc: use IS_ERR macro for error checking > > Done. Thanks! Andreas, can you fix this ASAP? Would be nice to have those working for v3.16 :) Once you have updated patches available I'll include them also to my randconfig builds. Unless the Kconfig options are nested they are exposed after few builds typically. Regards, Tony ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' 2014-05-22 14:24 ` Tony Lindgren @ 2014-05-23 8:19 ` Andreas Fenkart 2014-05-23 8:27 ` Balaji T K 0 siblings, 1 reply; 5+ messages in thread From: Andreas Fenkart @ 2014-05-23 8:19 UTC (permalink / raw) To: Tony Lindgren; +Cc: Chris Ball, Ulf Hansson, linux-mmc, balajitk 2014-05-22 16:24 GMT+02:00 Tony Lindgren <tony@atomide.com>: > * Chris Ball <chris@printf.net> [140522 05:42]: >> Hi, >> >> On Thu, May 22 2014, Ulf Hansson wrote: >> > I had a second look at Andreas Fenkart's patchset to enable SDIO irq >> > for omap. Those needs an additional iteration, since there are >> > unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other >> > Kconfigs as well). Apparently I had all the needed Kconfigs enabled >> > while I compile tested them. :-( > > Did you find this out with make randconfig? FYI after this patch I could deselect CONFIG_PM --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -111,7 +111,6 @@ config ARCH_OMAP2PLUS_TYPICAL select I2C_OMAP select MENELAUS if ARCH_OMAP2 select NEON if CPU_V7 - select PM_RUNTIME select REGULATOR select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4 > >> > I tried out doing a local re-base, to remove the related omap patches. >> > If you remove the patches below you won't get any conflicts for >> > omap_hsmmc. Can you do that? >> > >> > Andreas: >> > mmc: omap_hsmmc: Enable SDIO interrupt >> > mmc: omap_hsmmc: enable wakeup event for sdio OMAP4 >> > mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state >> > mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected >> > mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks >> > mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x >> > >> > Balaji: >> > mmc: omap_hsmmc: use IS_ERR macro for error checking >> >> Done. Thanks! > > Andreas, can you fix this ASAP? Would be nice to have those > working for v3.16 :) will send out updated patches soon > > Once you have updated patches available I'll include them > also to my randconfig builds. Unless the Kconfig options > are nested they are exposed after few builds typically. > > Regards, > > Tony ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' 2014-05-23 8:19 ` Andreas Fenkart @ 2014-05-23 8:27 ` Balaji T K 0 siblings, 0 replies; 5+ messages in thread From: Balaji T K @ 2014-05-23 8:27 UTC (permalink / raw) To: Andreas Fenkart; +Cc: Tony Lindgren, Chris Ball, Ulf Hansson, linux-mmc On Friday 23 May 2014 01:49 PM, Andreas Fenkart wrote: > 2014-05-22 16:24 GMT+02:00 Tony Lindgren <tony@atomide.com>: >> * Chris Ball <chris@printf.net> [140522 05:42]: >>> Hi, >>> >>> On Thu, May 22 2014, Ulf Hansson wrote: >>>> I had a second look at Andreas Fenkart's patchset to enable SDIO irq >>>> for omap. Those needs an additional iteration, since there are >>>> unresolved dependencies to CONFIG_PM_RUNTIME (and possibly to other >>>> Kconfigs as well). Apparently I had all the needed Kconfigs enabled >>>> while I compile tested them. :-( >> >> Did you find this out with make randconfig? > > FYI > > after this patch I could deselect CONFIG_PM > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -111,7 +111,6 @@ config ARCH_OMAP2PLUS_TYPICAL > select I2C_OMAP > select MENELAUS if ARCH_OMAP2 > select NEON if CPU_V7 > - select PM_RUNTIME > select REGULATOR > select TWL4030_CORE if ARCH_OMAP3 || ARCH_OMAP4 > select TWL4030_POWER if ARCH_OMAP3 || ARCH_OMAP4 > > >> >>>> I tried out doing a local re-base, to remove the related omap patches. >>>> If you remove the patches below you won't get any conflicts for >>>> omap_hsmmc. Can you do that? >>>> >>>> Andreas: >>>> mmc: omap_hsmmc: Enable SDIO interrupt >>>> mmc: omap_hsmmc: enable wakeup event for sdio OMAP4 >>>> mmc: omap_hsmmc: Extend debugfs by SDIO IRQ handling, runtime state >>>> mmc: omap_hsmmc: abort runtime suspend if pending sdio irq detected >>>> mmc: omap_hsmmc: switch default/idle pinctrl states in runtime hooks >>>> mmc: omap_hsmmc: Pin remux workaround to support SDIO interrupt on AM335x >>>> >>>> Balaji: >>>> mmc: omap_hsmmc: use IS_ERR macro for error checking >>> >>> Done. Thanks! >> >> Andreas, can you fix this ASAP? Would be nice to have those >> working for v3.16 :) > will send out updated patches soon Thanks Andreas, If it helps, how about sending the fix as separate patch, That way it will be easier for reviewing! ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-23 8:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <537de770.ItHqmb5BpaXWIlXq%fengguang.wu@intel.com>
2014-05-22 12:39 ` [mmc:mmc-next 79/96] drivers/mmc/host/omap_hsmmc.c:1841:30: error: 'struct dev_pm_info' has no member named 'runtime_status' Ulf Hansson
2014-05-22 12:41 ` Chris Ball
2014-05-22 14:24 ` Tony Lindgren
2014-05-23 8:19 ` Andreas Fenkart
2014-05-23 8:27 ` Balaji T K
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).