Re: [PATCH v2 1/2] mmc: sdhci: add init_card callback

[Steffen Trumtrar <s.trumtrar@pengutronix.de>]

On Fri, Jun 13, 2014 at 01:01:25PM +0200, Ulf Hansson wrote:
> On 13 June 2014 12:25, Steffen Trumtrar <s.trumtrar@pengutronix.de> wrote:
> > Currently host drivers using the sdhci-pltfm code can not configure the
> > host based on the type of card inserted.
> >
> > The sdio driver e.g. calls the card_init callback, so the host can now
> > know what card is used and configure itself accordingly.
> >
> > Provide a callback for users of the sdhci-pltfm code to use this callback
> > function.
> >
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> 
> At the first glance, this seems like a reasonable approach to your problem.
> 
> Though I wonder if the mmc core really behaves as what a host expect
> in this context. More precisely, the mmc core _only_ invokes
> host_ops->init_card() from the sdio initialization path. Don't your
> host need to be invoked for the SD/eMMC case as well?
> 

For my use-case this is okay. Though it sounds like this is not generic
enough. I'm open for suggestions.

> Do note that the ->init_card() function is also used to handle
> non-standard SDIO devices.
> 

Hm, the problem occured with a card that can't handle single transfers.
So, sounds non-standard to me.

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |