From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Markus Niebel <Markus.Niebel@tqs.de>,
linux-mmc <linux-mmc@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mmc: implement driver stage register handling
Date: Mon, 16 Jun 2014 12:48:06 +0100 [thread overview]
Message-ID: <20140616114806.GA23430@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAPDyKFotJr1UkKFs8vqaeh+=VqZvbxY6KmzDQ0HQKFkkr=07ug@mail.gmail.com>
On Mon, Jun 16, 2014 at 01:36:38PM +0200, Ulf Hansson wrote:
> On 23 May 2014 15:34, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > @@ -970,6 +971,9 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
> > goto free_card;
> > }
> >
> > + if (card->csd.dsr_imp && (host->dsr & 0xffff) == host->dsr)
>
> To clarify, maybe add an extra pair of parentheses around the above expression?
To which I say, don't you bloody dare. It's perfectly readable as it
is, it doesn't need any additional parenthesis.
Additional useless parenthesis detracts from readability. Don't encourage
stuch stuff.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-06-16 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 13:34 [PATCH] mmc: implement driver stage register handling Sascha Hauer
2014-06-16 11:36 ` Ulf Hansson
2014-06-16 11:48 ` Russell King - ARM Linux [this message]
2014-07-09 9:05 ` Markus Niebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140616114806.GA23430@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Markus.Niebel@tqs.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).