public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2
@ 2014-06-16 12:18 Jean Delvare
  2014-06-17  0:21 ` Haojian Zhuang
  0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2014-06-16 12:18 UTC (permalink / raw)
  To: linux-mmc, linux-kernel
  Cc: Chris Ball, Ulf Hansson, Eric Miao, Haojian Zhuang

I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
only needed on the MMP architecture. So add a hardware dependency on
ARCH_MMP, so that other users don't get to build useless drivers.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Chris Ball <chris@printf.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
---
Changes since v1:
 * Rebased on kernel 3.16-rc1

 drivers/mmc/host/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

--- linux-3.16-rc1.orig/drivers/mmc/host/Kconfig	2014-06-16 14:03:26.195946537 +0200
+++ linux-3.16-rc1/drivers/mmc/host/Kconfig	2014-06-16 14:04:02.128663037 +0200
@@ -217,6 +217,7 @@ config MMC_SDHCI_PXAV3
 	tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
 	depends on CLKDEV_LOOKUP
 	depends on MMC_SDHCI_PLTFM
+	depends on ARCH_MMP || COMPILE_TEST
 	default CPU_MMP2
 	help
 	  This selects the Marvell(R) PXAV3 SD Host Controller.
@@ -229,6 +230,7 @@ config MMC_SDHCI_PXAV2
 	tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
 	depends on CLKDEV_LOOKUP
 	depends on MMC_SDHCI_PLTFM
+	depends on ARCH_MMP || COMPILE_TEST
 	default CPU_PXA910
 	help
 	  This selects the Marvell(R) PXAV2 SD Host Controller.


-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2
  2014-06-16 12:18 [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2 Jean Delvare
@ 2014-06-17  0:21 ` Haojian Zhuang
  0 siblings, 0 replies; 2+ messages in thread
From: Haojian Zhuang @ 2014-06-17  0:21 UTC (permalink / raw)
  To: Jean Delvare
  Cc: linux-mmc, linux-kernel@vger.kernel.org, Chris Ball, Ulf Hansson,
	Eric Miao

On Mon, Jun 16, 2014 at 8:18 PM, Jean Delvare <jdelvare@suse.de> wrote:
> I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
> only needed on the MMP architecture. So add a hardware dependency on
> ARCH_MMP, so that other users don't get to build useless drivers.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Chris Ball <chris@printf.net>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Eric Miao <eric.y.miao@gmail.com>
> Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
> ---
> Changes since v1:
>  * Rebased on kernel 3.16-rc1
>
>  drivers/mmc/host/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-3.16-rc1.orig/drivers/mmc/host/Kconfig        2014-06-16 14:03:26.195946537 +0200
> +++ linux-3.16-rc1/drivers/mmc/host/Kconfig     2014-06-16 14:04:02.128663037 +0200
> @@ -217,6 +217,7 @@ config MMC_SDHCI_PXAV3
>         tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
>         depends on CLKDEV_LOOKUP
>         depends on MMC_SDHCI_PLTFM
> +       depends on ARCH_MMP || COMPILE_TEST
>         default CPU_MMP2
>         help
>           This selects the Marvell(R) PXAV3 SD Host Controller.
> @@ -229,6 +230,7 @@ config MMC_SDHCI_PXAV2
>         tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
>         depends on CLKDEV_LOOKUP
>         depends on MMC_SDHCI_PLTFM
> +       depends on ARCH_MMP || COMPILE_TEST
>         default CPU_PXA910
>         help
>           This selects the Marvell(R) PXAV2 SD Host Controller.
>
>

Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-17  0:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 12:18 [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2 Jean Delvare
2014-06-17  0:21 ` Haojian Zhuang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox