From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: rtsx: add dma transfer function Date: Wed, 18 Jun 2014 09:00:56 +0100 Message-ID: <20140618080056.GM21030@lee--X1> References: <9021eae37d96aa027d00ae4a7b6cd84dbbd1b6b5.1402037564.git.micky_ching@realsil.com.cn> <20140616122032.GS14323@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f181.google.com ([209.85.223.181]:37079 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933338AbaFRIBD (ORCPT ); Wed, 18 Jun 2014 04:01:03 -0400 Received: by mail-ie0-f181.google.com with SMTP id y20so388363ier.26 for ; Wed, 18 Jun 2014 01:01:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: micky , Samuel Ortiz , Chris Ball , devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-mmc , Greg Kroah-Hartman , Dan Carpenter , Roger , Wei WANG On Mon, 16 Jun 2014, Ulf Hansson wrote: > On 16 June 2014 14:20, Lee Jones wrote: > >> From: Micky Ching > >> > >> rtsx driver using a single function for transfer data, dma map/unm= ap are > >> placed in one fix function. We need map/unmap dma in different pla= ce(for > >> mmc async driver), so add three function for dma map, dma transfer= and > >> dma unmap. > >> > >> Signed-off-by: Micky Ching > >> --- > >> drivers/mfd/rtsx_pcr.c | 76 ++++++++++++++++++++++++++---= ------------- > >> include/linux/mfd/rtsx_pci.h | 6 ++++ > >> 2 files changed, 54 insertions(+), 28 deletions(-) > > > > I don't see any glaring issues with this patch. Does it rely on th= e > > first patch, or vise versa, or can it just be applied? >=20 > The mmc part in patch2 relies on this one, but please go ahead and > apply the mfd patch if you see it good. >=20 > I can later provide my ack for the mmc parts, in patch2, when it's a > reviewed properly and thus you can take it through your tree. There's no rush. Once you're happy with the MMC patch, Micky can submit them both again with my Ack on the MFD part and I'll take them as a set. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog