* [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code
@ 2014-06-20 7:19 Dan Carpenter
2014-06-20 11:41 ` Matt Porter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-06-20 7:19 UTC (permalink / raw)
To: Chris Ball
Cc: Ulf Hansson, Grant Likely, Rob Herring, Christian Daudt,
Russell King, Matt Porter, Sachin Kamat, Markus Mayer, Tim Kryger,
Axel Lin, linux-mmc, kernel-janitors
The debug printk says that 8bit is always true because of a '|' vs '&'
typo.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index dd780c3..2d3f3c0 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
dev_dbg(dev, "is_8bit=%c\n",
- (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
+ (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
ret = sdhci_bcm_kona_sd_reset(host);
if (ret)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code
2014-06-20 7:19 [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code Dan Carpenter
@ 2014-06-20 11:41 ` Matt Porter
0 siblings, 0 replies; 2+ messages in thread
From: Matt Porter @ 2014-06-20 11:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chris Ball, Ulf Hansson, Grant Likely, Rob Herring,
Christian Daudt, Russell King, Sachin Kamat, Markus Mayer,
Tim Kryger, Axel Lin, linux-mmc, kernel-janitors
On Fri, Jun 20, 2014 at 10:19:01AM +0300, Dan Carpenter wrote:
> The debug printk says that 8bit is always true because of a '|' vs '&'
> typo.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Matt Porter <mporter@linaro.org>
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index dd780c3..2d3f3c0 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -290,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
> ret = sdhci_bcm_kona_sd_reset(host);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-20 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 7:19 [patch] mmc: sdhci-bcm-kona: | vs & typo in debug code Dan Carpenter
2014-06-20 11:41 ` Matt Porter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).