From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: rtsx: add dma transfer function Date: Wed, 2 Jul 2014 13:15:30 +0100 Message-ID: <20140702121530.GF16724@lee--X1> References: <9021eae37d96aa027d00ae4a7b6cd84dbbd1b6b5.1402037564.git.micky_ching@realsil.com.cn> <20140616122032.GS14323@lee--X1> <20140618080056.GM21030@lee--X1> <53B3CD60.80302@realsil.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ie0-f175.google.com ([209.85.223.175]:39975 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbaGBMPh (ORCPT ); Wed, 2 Jul 2014 08:15:37 -0400 Received: by mail-ie0-f175.google.com with SMTP id tp5so9411797ieb.34 for ; Wed, 02 Jul 2014 05:15:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53B3CD60.80302@realsil.com.cn> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: micky Cc: Ulf Hansson , Samuel Ortiz , Chris Ball , devel@linuxdriverproject.org, "linux-kernel@vger.kernel.org" , linux-mmc , Greg Kroah-Hartman , Dan Carpenter , Roger , Wei WANG On Wed, 02 Jul 2014, micky wrote: > On 06/18/2014 04:00 PM, Lee Jones wrote: > >On Mon, 16 Jun 2014, Ulf Hansson wrote: > > > >>On 16 June 2014 14:20, Lee Jones wrote: > >>>>From: Micky Ching > >>>> > >>>>rtsx driver using a single function for transfer data, dma map/un= map are > >>>>placed in one fix function. We need map/unmap dma in different pl= ace(for > >>>>mmc async driver), so add three function for dma map, dma transfe= r and > >>>>dma unmap. > >>>> > >>>>Signed-off-by: Micky Ching > >>>>--- > >>>> drivers/mfd/rtsx_pcr.c | 76 ++++++++++++++++++++++++++-= --------------- > >>>> include/linux/mfd/rtsx_pci.h | 6 ++++ > >>>> 2 files changed, 54 insertions(+), 28 deletions(-) > >>>I don't see any glaring issues with this patch. Does it rely on t= he > >>>first patch, or vise versa, or can it just be applied? > >>The mmc part in patch2 relies on this one, but please go ahead and > >>apply the mfd patch if you see it good. > >> > >>I can later provide my ack for the mmc parts, in patch2, when it's = a > >>reviewed properly and thus you can take it through your tree. > >There's no rush. Once you're happy with the MMC patch, Micky can > >submit them both again with my Ack on the MFD part and I'll take the= m > >as a set. > > > Hi Lee, >=20 > Can you pick this patch directly? need resend it now? No need to resend, I'll get round to applying it from here. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog