From: Arnd Bergmann <arnd@arndb.de>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
arm-linux <linux-arm-kernel@lists.infradead.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
Jaehoon Chung <jh80.chung@samsung.com>,
Mark Brown <broonie@kernel.org>, Ben Dooks <ben-linux@fluff.org>
Subject: Re: [PATCH v3] s3cmci: port DMA code to dmaengine API
Date: Mon, 7 Jul 2014 23:12:39 +0200 [thread overview]
Message-ID: <201407072312.40687.arnd@arndb.de> (raw)
In-Reply-To: <CA+E=qVeS8DXTz6b9NnVNi4gFufMkf+iUrOU1A0+Ja8ehnBsrhQ@mail.gmail.com>
On Monday 07 July 2014, Vasily Khoruzhick wrote:
> On Mon, Jun 30, 2014 at 10:03 PM, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> > On Mon, Jun 23, 2014 at 2:31 PM, Vasily Khoruzhick <anarsoul@gmail.com> wrote:
> >>
> >> On 1 June 2014 20:22:09 Vasily Khoruzhick wrote:
> >> > Utilise new s3c24xx-dma dmaengine driver for DMA ops.
> >> >
> >> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> >> > ---
> >> > v2: - Don't store async dma descriptor, it's not used
> >> > - Request DMA channel via dma_request_slave_channel_compat() and use
> >> > hardcoded DMA channel.
> >> > - Add dependency on S3C24XX_DMAC (s3cmci uses filter function from it)
> >> > v3: - Use 'depends' instead of 'select' in Kconfig
> >> > - Drop useless controller registers reads from dma completion callback
> >>
> >> Ping?
> >
> > Ping?
>
> Could anyone tell me through which tree this patch should be merged?
> I'm pretty sure that I've included everyone from get_maintainer.pl
> output
> except LKML, but no response from maintainer so far.
I think you did everything right, Ulf or Chris should really pick up this
patch. The one thing you could improve is the changeset text which you
wrote as "Utilise new s3c24xx-dma dmaengine driver for DMA ops." What we
really need here is an explanation of why we want this, e.g. what problems
are solved by it etc. I definitely really want this patch as part of 3.17
so we can enabled multiplatform for the platforms that use this driver.
You should also list the
Acked-by: Arnd Bergmann <arnd@arndb.de>
line under your "Signed-off-by" line.
Arnd
next prev parent reply other threads:[~2014-07-07 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 17:22 [PATCH v3] s3cmci: port DMA code to dmaengine API Vasily Khoruzhick
2014-06-23 11:31 ` Vasily Khoruzhick
2014-06-30 19:03 ` Vasily Khoruzhick
2014-07-07 8:08 ` Vasily Khoruzhick
2014-07-07 21:12 ` Arnd Bergmann [this message]
2014-07-08 12:51 ` Ulf Hansson
2014-07-08 12:56 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201407072312.40687.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anarsoul@gmail.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=chris@printf.net \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox