From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [ulf.hansson-mmc:next 62/67] drivers/mmc/host/sdhci.c:1199:4: error: 'mmc' undeclared Date: Tue, 2 Sep 2014 10:17:44 +0800 Message-ID: <20140902021729.GA11563@shlinux1.ap.freescale.net> References: <54007fae.5BYLcypTZgZbcj+t%fengguang.wu@intel.com> <20140901024022.GA24746@shlinux1.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from mail-bn1blp0181.outbound.protection.outlook.com ([207.46.163.181]:5107 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751832AbaIBCit (ORCPT ); Mon, 1 Sep 2014 22:38:49 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: kbuild test robot , "kbuild-all@01.org" , linux-mmc On Mon, Sep 01, 2014 at 09:32:29AM +0200, Ulf Hansson wrote: > On 1 September 2014 04:40, Dong Aisheng wrote: > > Hi Ulf, > > > > On Fri, Aug 29, 2014 at 09:27:10PM +0800, kbuild test robot wrote: > >> tree: git://git.linaro.org/people/ulf.hansson/mmc next > >> head: 1a3c4f637e87dbdda6000b5d5cd9b590d3ec6f46 > >> commit: cdfd9a2374ab63189ddeb5bf456bd3418ec559ec [62/67] mmc: sdhci: add platfrom get_max_timeout_count hook > >> config: make ARCH=x86_64 allmodconfig > >> > >> Note: the ulf.hansson-mmc/next HEAD 1a3c4f637e87dbdda6000b5d5cd9b590d3ec6f46 builds fine. > >> It only hurts bisectibility. > >> > >> All error/warnings: > >> > >> drivers/mmc/host/sdhci.c: In function 'sdhci_set_clock': > >> >> drivers/mmc/host/sdhci.c:1199:4: error: 'mmc' undeclared (first use in this function) > >> mmc->max_busy_timeout = > >> ^ > >> drivers/mmc/host/sdhci.c:1199:4: note: each undeclared identifier is reported only once for each function it appears in > >> > >> vim +/mmc +1199 drivers/mmc/host/sdhci.c > >> > >> 1193 > >> 1194 clock_set: > >> 1195 if (real_div) { > >> 1196 host->mmc->actual_clock = (host->max_clk * clk_mul) / real_div; > >> 1197 if (host->quirks & SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK) { > >> 1198 host->timeout_clk = host->mmc->actual_clock / 1000; > >> > 1199 mmc->max_busy_timeout = > >> 1200 host->ops->get_max_timeout_count ? > >> 1201 host->ops->get_max_timeout_count(host) : > >> 1202 1 << 27; > >> > > > > Sorry for this bisect issue. > > Can you squash the following changes into the original commit to fix it? > > > > commit 94c10a5d2e78f7dddb67e0881799448ed5d650d3 > > Author: Dong Aisheng > > Date: Mon Sep 1 10:33:16 2014 +0800 > > > > mmc: sdhci: fix bisect issue > > > > Signed-off-by: Dong Aisheng > > Hi Dong, > > Thanks for fix, I have squashed it into the original commit. > > Additionally, while rebasing the branch the last patch in this series > hit a merge conflict, but managed to fix that myself. Still you may > want to have a look at the end result to verify I didn't screw up. > I checked it's ok. Thanks a lot. Regards Dong Aisheng > Kind regards > Uffe