From: Ian Molton <ian.molton@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-mmc@vger.kernel.org, chris@printf.net,
ulf.hansson@linaro.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Mon, 15 Sep 2014 12:14:30 +0100 [thread overview]
Message-ID: <20140915121430.b19ec6531ef5336fdd683c85@codethink.co.uk> (raw)
In-Reply-To: <3179866.4yEKrAKQ30@wasted.cogentembedded.com>
Seems reasonable,
Acked-by: Ian Molton <ian.molton@codethink.co.uk>
-Ian
On Sun, 14 Sep 2014 23:51:24 +0400
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> I spent a couple of days with the driver just hanging due to me forgetting to
> specify the external crystal frequency, so that clk_get_rate() returned 0 and
> thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
> acceptable behavior, so I suggest that the minimum frequency is checked for 0
> in tmio_mmc_host_probe().
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Cc: stable@vger.kernel.org
>
> ---
> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.
>
> Changes in version 3:
> - added Cc: stable.
>
> Changes in version 2:
> - fixed grammar in the changelog.
>
> drivers/mmc/host/tmio_mmc_pio.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> Index: mmc/drivers/mmc/host/tmio_mmc_pio.c
> ===================================================================
> --- mmc.orig/drivers/mmc/host/tmio_mmc_pio.c
> +++ mmc/drivers/mmc/host/tmio_mmc_pio.c
> @@ -1044,6 +1044,15 @@ int tmio_mmc_host_probe(struct tmio_mmc_
> }
>
> /*
> + * Check the sanity of mmc->f_min to prevent tmio_mmc_set_clock() from
> + * looping forever...
> + */
> + if (mmc->f_min == 0) {
> + ret = -EINVAL;
> + goto pm_disable;
> + }
> +
> + /*
> * There are 4 different scenarios for the card detection:
> * 1) an external gpio irq handles the cd (best for power savings)
> * 2) internal sdhi irq handles the cd
>
--
Ian Molton <ian.molton@codethink.co.uk>
next prev parent reply other threads:[~2014-09-15 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 19:51 [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Sergei Shtylyov
2014-09-15 11:14 ` Ian Molton [this message]
2014-09-17 22:03 ` Ulf Hansson
2014-09-18 16:54 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915121430.b19ec6531ef5336fdd683c85@codethink.co.uk \
--to=ian.molton@codethink.co.uk \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox