From: Tony Lindgren <tony@atomide.com>
To: Andreas Fenkart <afenkart@gmail.com>
Cc: linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
Balaji T K <balajitk@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
pascal.huerst@gmail.com
Subject: Re: [PATCH 0/6] unshare and simplify omap_hsmmc platform struct
Date: Tue, 23 Sep 2014 09:22:49 -0700 [thread overview]
Message-ID: <20140923162249.GF2451@atomide.com> (raw)
In-Reply-To: <1411386911-8158-1-git-send-email-afenkart@gmail.com>
* Andreas Fenkart <afenkart@gmail.com> [140922 04:55]:
> mmci and omap_hsmmc share very little fields in the platform
> struct. unsharing significantly simplifies the omap_hsmmc driver
I think this is good to do. I was hoping we could drop omap3
legacy booting support and completely get rid of the platform_data
for omap_hsmmc. But that happens when it happens, so let's do
this meanwhile to remove some dependencies for the omap_hsmmc
clean-up work.
Some patches have missing descriptions, can you please add those?
Once the patches have proper descriptions, and assuming this
does not break the omap3 legacy booting with the board-*.c
files, please feel free to add:
Acked-by: Tony Lindgren <tony@atomide.com>
As it seems this is best merged via the MMC tree.
Regards,
Tony
> Andreas Fenkart (6):
> omap_hsmmc: unshare platform data struct with mmci driver
> omap_hsmmc: remove unused callbacks from platform data struct
> omap_hsmmc: remove unused fields in platform_data
> omap_hsmmc: remove unused get_context_loss_count callback
> omap_hsmmc: remove un-initialized callbacks from platform data
> omap_hsmmc: remove un-initialized get_cover_state callback
>
> arch/arm/mach-omap2/hsmmc.c | 61 ++--------
> arch/arm/mach-omap2/hsmmc.h | 10 --
> arch/arm/mach-omap2/mmc.h | 6 +-
> .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 6 +-
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 6 +-
> drivers/mmc/host/omap_hsmmc.c | 133 +++------------------
> include/linux/platform_data/hsmmc-omap.h | 103 ++++++++++++++++
> 7 files changed, 142 insertions(+), 183 deletions(-)
> create mode 100644 include/linux/platform_data/hsmmc-omap.h
next prev parent reply other threads:[~2014-09-23 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 11:55 [PATCH 0/6] unshare and simplify omap_hsmmc platform struct Andreas Fenkart
2014-09-22 11:55 ` [PATCH 1/6] omap_hsmmc: unshare platform data struct with mmci driver Andreas Fenkart
2014-09-22 11:55 ` [PATCH 2/6] omap_hsmmc: remove unused callbacks from platform data struct Andreas Fenkart
2014-09-22 11:55 ` [PATCH 3/6] omap_hsmmc: remove unused fields in platform_data Andreas Fenkart
2014-09-22 11:55 ` [PATCH 4/6] omap_hsmmc: remove unused get_context_loss_count callback Andreas Fenkart
2014-09-22 11:55 ` [PATCH 5/6] omap_hsmmc: remove un-initialized callbacks from platform data Andreas Fenkart
2014-09-22 11:55 ` [PATCH 6/6] omap_hsmmc: remove un-initialized get_cover_state callback Andreas Fenkart
2014-09-23 16:22 ` Tony Lindgren [this message]
2014-09-24 8:55 ` [PATCH 0/6] unshare and simplify omap_hsmmc platform struct Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923162249.GF2451@atomide.com \
--to=tony@atomide.com \
--cc=afenkart@gmail.com \
--cc=balajitk@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pascal.huerst@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox