From: Sascha Hauer <s.hauer@pengutronix.de>
To: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
Cc: chris@printf.net, ulf.hansson@linaro.org, shc_work@mail.ru,
peter.griffin@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linucppc-dev@lists.ozlabs.org,
agust@denx.de, gsi@denx.de, sbabic@denx.de
Subject: Re: [PATCH 1/2] mmc: mxcmmc: fix race condition when dma finish a data transfer
Date: Wed, 8 Oct 2014 08:49:02 +0200 [thread overview]
Message-ID: <20141008064902.GA4992@pengutronix.de> (raw)
In-Reply-To: <1412089178-21946-2-git-send-email-matteo.facchinetti@sirius-es.it>
On Tue, Sep 30, 2014 at 04:59:37PM +0200, Matteo Facchinetti wrote:
> From: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
>
> In accordance with the other drivers that using the dma engine,
> fix it, leaving *only* to dma driver the complete control to
> ending the read operation.
>
> Removing STATUS_READ_OP_DONE event activation, has as effect
> to force mxcmci driver to handle the finish data transfer only
> by mxcmci dma callback.
>
> Signed-off-by: Matteo Facchinetti <matteo.facchinetti@sirius-es.it>
I can't test this currently, but it looks sane to me and I assume you
invested quite some time to make sure the patch behaves correctly.
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2014-10-08 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 14:59 [PATCH 0/2] mxcmmc driver fixes Matteo Facchinetti
2014-09-30 14:59 ` [PATCH 1/2] mmc: mxcmmc: fix race condition when dma finish a data transfer Matteo Facchinetti
2014-10-08 6:49 ` Sascha Hauer [this message]
2014-10-27 12:12 ` Ulf Hansson
2014-09-30 14:59 ` [PATCH 2/2] mmc: mxcmmc: fix the default value for available voltages into mxcmci_probe Matteo Facchinetti
2014-10-08 6:46 ` Sascha Hauer
2014-10-07 12:50 ` [PATCH 0/2] mxcmmc driver fixes Matteo Facchinetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008064902.GA4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=agust@denx.de \
--cc=chris@printf.net \
--cc=gsi@denx.de \
--cc=linucppc-dev@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matteo.facchinetti@sirius-es.it \
--cc=peter.griffin@linaro.org \
--cc=sbabic@denx.de \
--cc=shc_work@mail.ru \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox