From: Baruch Siach <baruch@tkos.co.il>
To: Chris Ball <chris@printf.net>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrei Warkentin <andrey.warkentin@gmail.com>
Subject: Re: [PATCH] mmc: block: add newline to sysfs display of force_ro
Date: Tue, 21 Oct 2014 12:20:13 +0300 [thread overview]
Message-ID: <20141021092012.GB2220@tarshish> (raw)
In-Reply-To: <f7fa9dd28f967c578a07333d92eba159f3f63863.1411369971.git.baruch@tkos.co.il>
Hi Chris, Ulf,
Ping?
Not a big deal, I guess, but still nice to have for consistency sake.
When applying please make sure to change Andrei's email address.
Thanks,
baruch
On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
> Make force_ro consistent with other sysfs entries.
>
> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
> Cc: Andrei Warkentin <andreiw@motorola.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index ede41f05c392..dad364b09952 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
> int ret;
> struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>
> - ret = snprintf(buf, PAGE_SIZE, "%d",
> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
> get_disk_ro(dev_to_disk(dev)) ^
> md->read_only);
> mmc_blk_put(md);
> --
> 2.1.0
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-10-21 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 7:12 [PATCH] mmc: block: add newline to sysfs display of force_ro Baruch Siach
2014-09-22 7:18 ` Baruch Siach
2014-10-21 9:20 ` Baruch Siach [this message]
2014-10-27 11:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021092012.GB2220@tarshish \
--to=baruch@tkos.co.il \
--cc=andrey.warkentin@gmail.com \
--cc=chris@printf.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox