From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH] mmc: block: add newline to sysfs display of force_ro Date: Tue, 21 Oct 2014 12:20:13 +0300 Message-ID: <20141021092012.GB2220@tarshish> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from guitar.tcltek.co.il ([192.115.133.116]:44188 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbaJUJUX (ORCPT ); Tue, 21 Oct 2014 05:20:23 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball , Ulf Hansson Cc: linux-mmc@vger.kernel.org, Greg Kroah-Hartman , Andrei Warkentin Hi Chris, Ulf, Ping? Not a big deal, I guess, but still nice to have for consistency sake. When applying please make sure to change Andrei's email address. Thanks, baruch On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote: > Make force_ro consistent with other sysfs entries. > > Fixes: 371a689f64b0d ('mmc: MMC boot partitions support') > Cc: Andrei Warkentin > Signed-off-by: Baruch Siach > --- > drivers/mmc/card/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index ede41f05c392..dad364b09952 100644 > --- a/drivers/mmc/card/block.c > +++ b/drivers/mmc/card/block.c > @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr, > int ret; > struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev)); > > - ret = snprintf(buf, PAGE_SIZE, "%d", > + ret = snprintf(buf, PAGE_SIZE, "%d\n", > get_disk_ro(dev_to_disk(dev)) ^ > md->read_only); > mmc_blk_put(md); > -- > 2.1.0 -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -