* [PATCH] mmc: block: add newline to sysfs display of force_ro
@ 2014-09-22 7:12 Baruch Siach
2014-09-22 7:18 ` Baruch Siach
2014-10-21 9:20 ` Baruch Siach
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2014-09-22 7:12 UTC (permalink / raw)
To: Chris Ball, Ulf Hansson
Cc: linux-mmc, Greg Kroah-Hartman, Baruch Siach, Andrei Warkentin
Make force_ro consistent with other sysfs entries.
Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
Cc: Andrei Warkentin <andreiw@motorola.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/mmc/card/block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index ede41f05c392..dad364b09952 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
int ret;
struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
- ret = snprintf(buf, PAGE_SIZE, "%d",
+ ret = snprintf(buf, PAGE_SIZE, "%d\n",
get_disk_ro(dev_to_disk(dev)) ^
md->read_only);
mmc_blk_put(md);
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: block: add newline to sysfs display of force_ro
2014-09-22 7:12 [PATCH] mmc: block: add newline to sysfs display of force_ro Baruch Siach
@ 2014-09-22 7:18 ` Baruch Siach
2014-10-21 9:20 ` Baruch Siach
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-09-22 7:18 UTC (permalink / raw)
To: Chris Ball, Ulf Hansson; +Cc: linux-mmc, Greg Kroah-Hartman, Andrei Warkentin
Hi Cris, Ulf,
On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
> Make force_ro consistent with other sysfs entries.
>
> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
> Cc: Andrei Warkentin <andreiw@motorola.com>
Andrei's address is bouncing. Added his gmail address instead:
Cc: Andrei Warkentin <andrey.warkentin@gmail.com>
baruch
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index ede41f05c392..dad364b09952 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
> int ret;
> struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>
> - ret = snprintf(buf, PAGE_SIZE, "%d",
> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
> get_disk_ro(dev_to_disk(dev)) ^
> md->read_only);
> mmc_blk_put(md);
> --
> 2.1.0
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: block: add newline to sysfs display of force_ro
2014-09-22 7:12 [PATCH] mmc: block: add newline to sysfs display of force_ro Baruch Siach
2014-09-22 7:18 ` Baruch Siach
@ 2014-10-21 9:20 ` Baruch Siach
2014-10-27 11:29 ` Ulf Hansson
1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2014-10-21 9:20 UTC (permalink / raw)
To: Chris Ball, Ulf Hansson; +Cc: linux-mmc, Greg Kroah-Hartman, Andrei Warkentin
Hi Chris, Ulf,
Ping?
Not a big deal, I guess, but still nice to have for consistency sake.
When applying please make sure to change Andrei's email address.
Thanks,
baruch
On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
> Make force_ro consistent with other sysfs entries.
>
> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
> Cc: Andrei Warkentin <andreiw@motorola.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mmc/card/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index ede41f05c392..dad364b09952 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
> int ret;
> struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>
> - ret = snprintf(buf, PAGE_SIZE, "%d",
> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
> get_disk_ro(dev_to_disk(dev)) ^
> md->read_only);
> mmc_blk_put(md);
> --
> 2.1.0
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: block: add newline to sysfs display of force_ro
2014-10-21 9:20 ` Baruch Siach
@ 2014-10-27 11:29 ` Ulf Hansson
0 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2014-10-27 11:29 UTC (permalink / raw)
To: Baruch Siach; +Cc: Chris Ball, linux-mmc, Greg Kroah-Hartman, Andrei Warkentin
On 21 October 2014 11:20, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Chris, Ulf,
>
> Ping?
>
> Not a big deal, I guess, but still nice to have for consistency sake.
>
> When applying please make sure to change Andrei's email address.
Thanks! Applied for next!
Kind regards
Uffe
>
> Thanks,
> baruch
>
> On Mon, Sep 22, 2014 at 10:12:51AM +0300, Baruch Siach wrote:
>> Make force_ro consistent with other sysfs entries.
>>
>> Fixes: 371a689f64b0d ('mmc: MMC boot partitions support')
>> Cc: Andrei Warkentin <andreiw@motorola.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> drivers/mmc/card/block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
>> index ede41f05c392..dad364b09952 100644
>> --- a/drivers/mmc/card/block.c
>> +++ b/drivers/mmc/card/block.c
>> @@ -260,7 +260,7 @@ static ssize_t force_ro_show(struct device *dev, struct device_attribute *attr,
>> int ret;
>> struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev));
>>
>> - ret = snprintf(buf, PAGE_SIZE, "%d",
>> + ret = snprintf(buf, PAGE_SIZE, "%d\n",
>> get_disk_ro(dev_to_disk(dev)) ^
>> md->read_only);
>> mmc_blk_put(md);
>> --
>> 2.1.0
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-27 11:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-22 7:12 [PATCH] mmc: block: add newline to sysfs display of force_ro Baruch Siach
2014-09-22 7:18 ` Baruch Siach
2014-10-21 9:20 ` Baruch Siach
2014-10-27 11:29 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox