Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

Ulf Hansson
2014-11-19T10:14:24Z

On 8 November 2014 00:52, NeilBrown <neilb@suse.de> wrote:
> omap_hsmmc currently duplicates some work that can be done for
> it by common code, and consequently does not benefit from extra
> functionality in that common code.
>
> In particular, mmc_of_parse and the slot-gpio library are not used.
>
> This set of patches allows omap_hsmmc to use that common
> functionality, and benefit from any extra devicetree parsing
> that it performs.
>
> The one awkward part of this change is that omap_hsmmc has an
> interrupt handler for 'card detect' which does more than the
> common code.
> I see three options:
> 1 - move that functionality into common code
> 2 - discard that functionality
> 3 - allow the common code to be configured to use a device-specific
> card detect interrupt.
>
> This series implements '3'. I suspect a mix of '1' and '2' would
> be a better choice but I know no of the history or justification
> for those differences.
>
> My preference would be for this series to be applied (if there are
> no other issues) and if there are opinions about effecting '1' or '2',
> they can be done with subsequent patches.
>
> Thanks,
> NeilBrown
>

I like the looks of this patchset, but it needs a rebase.

Kind regards
Uffe

>
> ---
>
> NeilBrown (3):
> mmc: omap_hsmmc: remove prepare/complete system suspend support.
> mmc: omap_hsmmc: use slot-gpio library for gpio support.
> mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration.
>
>
> drivers/mmc/core/slot-gpio.c | 21 ++++
> drivers/mmc/host/omap_hsmmc.c | 158 +++++---------------------------
> include/linux/mmc/slot-gpio.h | 2
> include/linux/platform_data/mmc-omap.h | 4 -
> 4 files changed, 47 insertions(+), 138 deletions(-)
>
> --
> Signature
>