Re: [PATCH v4] mmc: add Toshiba PCI SD controller driver

[Ondrej Zary <linux@rainbow-software.org>]

On Tuesday 11 November 2014, Ulf Hansson wrote:
> On 10 November 2014 17:58, Ondrej Zary <linux@rainbow-software.org> wrote:
> > This patch resurrects an old never-finished driver for Toshiba PCI SD
> > controllers found in some older Toshiba laptops (such as Portege R100):
> >
> > 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA
> > Controller [1179:0805] (rev 05)
> >
> > The code is fixed, cleaned up and successfully tested with SD, SDHC, SDXC
> > and MMC cards on Portege R100. (MMC cards don't even work in Windows!)
> > SDIO probably does not work (don't have any SDIO card).
> >
> > The hardware is slow (around 2 MB/s - same in Windows) because it does
> > not support bus mastering (busmaster enable bit cannot be set in PCI
> > control reg). Also the card clock is limited to 16MHz (33MHz PCI clock
> > divided by 2).
> >
> > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
>
> Hi Ondrej,
>
> I get these compiler warning while building for x86. Can you please fix
> them.
>
> ../drivers/mmc/host/toshsd.c: In function ‘toshsd_init’:
> ../drivers/mmc/host/toshsd.c:70:9: warning: large integer implicitly
> truncated to unsigned type [-Woverflow]
>          host->ioaddr + SD_INTMASKCARD);
>          ^

Which GCC version did you use? I get no warnings with 4.7.2 (Debian Stable).

-- 
Ondrej Zary