From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz
Date: Thu, 13 Nov 2014 09:24:48 +0900 [thread overview]
Message-ID: <20141113002446.GB9195@verge.net.au> (raw)
In-Reply-To: <87sihoklaj.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Nov 13, 2014 at 12:15:58AM +0000, Kuninori Morimoto wrote:
>
> Hi Kaneko-san
>
> > From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> >
> > Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> (snip)
> > + if (np && !of_property_read_u32(np, "renesas,clk-rate", &clk_rate)) {
> > + if (clk_rate) {
> > + ret = clk_set_rate(host->hclk, clk_rate);
> > + if (ret < 0)
> > + dev_err(&pdev->dev,
> > + "cannot set clock rate: %d\n", ret);
> > + }
> > + }
>
> I guess this is came from BSP, and you have similar
> bindings on sh_mobile_sdhi.c too.
> But, we need to use "standard" method, not BSP original
Hi Morimoto-san,
you are correct in assuming that this patch came from the BSP.
Is your opinion that a) changing the clock rate is good but
b) it needs to be done using a standard method?
If so, is the main change required to use a standard binding string
rather than "renesas,clk-rate"? Is the driver change above needed at all?
next prev parent reply other threads:[~2014-11-13 0:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 6:42 [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz Yoshihiro Kaneko
2014-11-12 8:37 ` Ulf Hansson
2014-11-12 13:40 ` Sergei Shtylyov
2014-11-13 0:15 ` Kuninori Morimoto
2014-11-13 0:24 ` Simon Horman [this message]
2014-11-13 1:34 ` Kuninori Morimoto
2014-11-21 4:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113002446.GB9195@verge.net.au \
--to=horms@verge.net.au \
--cc=chris@printf.net \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox