From: Lee Jones <lee.jones@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Chris Ball <cjb@laptop.org>, Simon <horms@verge.net.au>,
Linux-SH <linux-sh@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 07/17] mmc: tmio: tmio_mmc_host has .bus_shift
Date: Tue, 20 Jan 2015 09:35:21 +0000 [thread overview]
Message-ID: <20150120093521.GE5767@x1> (raw)
In-Reply-To: <CAPDyKFojRTY51FEe=0H072VVA8hCFGfuT+wJLvdKEJ8DWs-+2w@mail.gmail.com>
On Tue, 20 Jan 2015, Ulf Hansson wrote:
> + MFD maintainer
>
> On 13 January 2015 at 05:58, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Current .bus_shift is implemented under tmio_mmc_data.
> > It goes to tmio_mmc_host by this patch.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > drivers/mmc/host/sh_mobile_sdhi.c | 5 ++---
> > drivers/mmc/host/tmio_mmc.c | 5 +++--
> > drivers/mmc/host/tmio_mmc.h | 17 +++++++++--------
> > drivers/mmc/host/tmio_mmc_dma.c | 2 +-
> > include/linux/mfd/tmio.h | 1 -
Acked-by: Lee Jones <lee.jones@linaro.org>
> > 5 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> > index c92efe5..0db2a0a 100644
> > --- a/drivers/mmc/host/sh_mobile_sdhi.c
> > +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> > @@ -218,6 +218,8 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
> > host->clk_enable = sh_mobile_sdhi_clk_enable;
> > host->clk_disable = sh_mobile_sdhi_clk_disable;
> > host->multi_io_quirk = sh_mobile_sdhi_multi_io_quirk;
> > + /* SD control register space size is 0x100, 0x200 for bus_shift=1 */
> > + host->bus_shift = resource_size(res) >> 9;
> >
> > mmc_data->capabilities = MMC_CAP_MMC_HIGHSPEED;
> > if (p) {
> > @@ -277,9 +279,6 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
> > dma_priv->dma_rx_offset = of_data->dma_rx_offset;
> > }
> >
> > - /* SD control register space size is 0x100, 0x200 for bus_shift=1 */
> > - mmc_data->bus_shift = resource_size(res) >> 9;
> > -
> > ret = tmio_mmc_host_probe(host, mmc_data);
> > if (ret < 0)
> > goto efree;
> > diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
> > index f47ae08..9e8723d 100644
> > --- a/drivers/mmc/host/tmio_mmc.c
> > +++ b/drivers/mmc/host/tmio_mmc.c
> > @@ -88,14 +88,15 @@ static int tmio_mmc_probe(struct platform_device *pdev)
> > if (!res)
> > return -EINVAL;
> >
> > - /* SD control register space size is 0x200, 0x400 for bus_shift=1 */
> > - pdata->bus_shift = resource_size(res) >> 10;
> > pdata->flags |= TMIO_MMC_HAVE_HIGH_REG;
> >
> > host = tmio_mmc_host_alloc(pdev);
> > if (!host)
> > goto cell_disable;
> >
> > + /* SD control register space size is 0x200, 0x400 for bus_shift=1 */
> > + host->bus_shift = resource_size(res) >> 10;
> > +
> > ret = tmio_mmc_host_probe(host, pdata);
> > if (ret)
> > goto host_free;
> > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> > index 263256c..a5d30bf 100644
> > --- a/drivers/mmc/host/tmio_mmc.h
> > +++ b/drivers/mmc/host/tmio_mmc.h
> > @@ -66,6 +66,7 @@ struct tmio_mmc_host {
> > struct scatterlist *sg_orig;
> > unsigned int sg_len;
> > unsigned int sg_off;
> > + unsigned long bus_shift;
> >
> > struct platform_device *pdev;
> > struct tmio_mmc_data *pdata;
> > @@ -169,19 +170,19 @@ int tmio_mmc_host_runtime_resume(struct device *dev);
> >
> > static inline u16 sd_ctrl_read16(struct tmio_mmc_host *host, int addr)
> > {
> > - return readw(host->ctl + (addr << host->pdata->bus_shift));
> > + return readw(host->ctl + (addr << host->bus_shift));
> > }
> >
> > static inline void sd_ctrl_read16_rep(struct tmio_mmc_host *host, int addr,
> > u16 *buf, int count)
> > {
> > - readsw(host->ctl + (addr << host->pdata->bus_shift), buf, count);
> > + readsw(host->ctl + (addr << host->bus_shift), buf, count);
> > }
> >
> > static inline u32 sd_ctrl_read32(struct tmio_mmc_host *host, int addr)
> > {
> > - return readw(host->ctl + (addr << host->pdata->bus_shift)) |
> > - readw(host->ctl + ((addr + 2) << host->pdata->bus_shift)) << 16;
> > + return readw(host->ctl + (addr << host->bus_shift)) |
> > + readw(host->ctl + ((addr + 2) << host->bus_shift)) << 16;
> > }
> >
> > static inline void sd_ctrl_write16(struct tmio_mmc_host *host, int addr, u16 val)
> > @@ -191,19 +192,19 @@ static inline void sd_ctrl_write16(struct tmio_mmc_host *host, int addr, u16 val
> > */
> > if (host->write16_hook && host->write16_hook(host, addr))
> > return;
> > - writew(val, host->ctl + (addr << host->pdata->bus_shift));
> > + writew(val, host->ctl + (addr << host->bus_shift));
> > }
> >
> > static inline void sd_ctrl_write16_rep(struct tmio_mmc_host *host, int addr,
> > u16 *buf, int count)
> > {
> > - writesw(host->ctl + (addr << host->pdata->bus_shift), buf, count);
> > + writesw(host->ctl + (addr << host->bus_shift), buf, count);
> > }
> >
> > static inline void sd_ctrl_write32(struct tmio_mmc_host *host, int addr, u32 val)
> > {
> > - writew(val, host->ctl + (addr << host->pdata->bus_shift));
> > - writew(val >> 16, host->ctl + ((addr + 2) << host->pdata->bus_shift));
> > + writew(val, host->ctl + (addr << host->bus_shift));
> > + writew(val >> 16, host->ctl + ((addr + 2) << host->bus_shift));
> > }
> >
> >
> > diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host/tmio_mmc_dma.c
> > index 6c214d6..ee0131e 100644
> > --- a/drivers/mmc/host/tmio_mmc_dma.c
> > +++ b/drivers/mmc/host/tmio_mmc_dma.c
> > @@ -289,7 +289,7 @@ void tmio_mmc_request_dma(struct tmio_mmc_host *host, struct tmio_mmc_data *pdat
> > if (host->dma->chan_priv_tx)
> > cfg.slave_id = host->dma->slave_id_tx;
> > cfg.direction = DMA_MEM_TO_DEV;
> > - cfg.dst_addr = res->start + (CTL_SD_DATA_PORT << host->pdata->bus_shift);
> > + cfg.dst_addr = res->start + (CTL_SD_DATA_PORT << host->bus_shift);
> > cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
> > cfg.src_addr = 0;
> > ret = dmaengine_slave_config(host->chan_tx, &cfg);
> > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > index 3edaa17..7a5c279 100644
> > --- a/include/linux/mfd/tmio.h
> > +++ b/include/linux/mfd/tmio.h
> > @@ -120,7 +120,6 @@ struct tmio_mmc_data {
> > unsigned long capabilities;
> > unsigned long capabilities2;
> > unsigned long flags;
> > - unsigned long bus_shift;
> > u32 ocr_mask; /* available voltages */
> > unsigned int cd_gpio;
> > void (*set_pwr)(struct platform_device *host, int state);
> >
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-20 9:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201501131902.WqokttpY%fengguang.wu@intel.com>
2015-01-13 4:56 ` [PATCH 0/17 v2] tmio: mmc: header cleanup / sh_mobile_cleanup Kuninori Morimoto
2015-01-13 4:57 ` [PATCH 01/17] mmc: tmio: add tmio_mmc_host_alloc/free() Kuninori Morimoto
2015-01-20 9:10 ` Ulf Hansson
2015-01-20 9:38 ` Lee Jones
2015-01-13 4:57 ` [PATCH 02/17] mmc: tmio: tmio_mmc_host has .dma Kuninori Morimoto
2015-01-20 9:10 ` Ulf Hansson
2015-01-20 9:37 ` Lee Jones
2015-01-13 4:57 ` [PATCH 03/17] mmc: tmio: tmio_mmc_host has .write16_hook Kuninori Morimoto
2015-01-20 9:11 ` Ulf Hansson
2015-01-20 9:37 ` Lee Jones
2015-01-13 4:57 ` [PATCH 04/17] mmc: tmio: tmio_mmc_host has .clk_enable Kuninori Morimoto
2015-01-20 9:11 ` Ulf Hansson
2015-01-20 9:36 ` Lee Jones
2015-01-13 4:58 ` [PATCH 05/17] mmc: tmio: tmio_mmc_host has .clk_disable Kuninori Morimoto
2015-01-20 9:11 ` Ulf Hansson
2015-01-20 9:36 ` Lee Jones
2015-01-13 4:58 ` [PATCH 06/17] mmc: tmio: tmio_mmc_host has .multi_io_quirk Kuninori Morimoto
2015-01-20 9:12 ` Ulf Hansson
2015-01-20 9:35 ` Lee Jones
2015-01-13 4:58 ` [PATCH 07/17] mmc: tmio: tmio_mmc_host has .bus_shift Kuninori Morimoto
2015-01-20 9:12 ` Ulf Hansson
2015-01-20 9:35 ` Lee Jones [this message]
2015-01-13 4:58 ` [PATCH 08/17] mmc: tmio: tmio_mmc_data has .alignment_shift Kuninori Morimoto
2015-01-20 9:13 ` Ulf Hansson
2015-01-20 9:34 ` Lee Jones
2015-01-13 4:58 ` [PATCH 09/17] mmc: tmio: tmio_mmc_data has .dma_rx_offset Kuninori Morimoto
2015-01-20 9:13 ` Ulf Hansson
2015-01-20 9:34 ` Lee Jones
2015-01-13 4:59 ` [PATCH 10/17] mmc: tmio: add .enable_dma on tmio_mmc_data Kuninori Morimoto
2015-01-13 4:59 ` [PATCH 11/17] mmc: tmio: enable SoC specific DMA buswidth settings Kuninori Morimoto
2015-01-13 4:59 ` [PATCH 12/17] mmc: sh_mobile_sdhi: remove .init/.cleanup Kuninori Morimoto
2015-01-13 4:59 ` [PATCH 13/17] mmc: sh_mobile_sdhi: tidyup mmc_data->bus_shift for latest SoC Kuninori Morimoto
2015-01-13 4:59 ` [PATCH 14/17] mmc: sh_mobile_sdhi: add new macro for mmc_host to sh_mobile_sdhi Kuninori Morimoto
2015-01-13 4:59 ` [PATCH 15/17] mmc: sh_mobile_sdhi: use .enable_dma Kuninori Morimoto
2015-01-13 5:00 ` [PATCH 16/17] mmc: sh_mobile_sdhi: enable 32bit DMA access Kuninori Morimoto
2015-01-13 5:00 ` [PATCH 17/17] mmc: tmio: remove TMIO_MMC_HAVE_CTL_DMA_REG flag Kuninori Morimoto
2015-01-20 9:14 ` Ulf Hansson
2015-01-20 9:33 ` Lee Jones
2015-01-13 9:35 ` [PATCH 0/17 v2] tmio: mmc: header cleanup / sh_mobile_cleanup Ulf Hansson
2015-01-14 8:30 ` [PATCH] mmc: tmio: add missing EXPORT_SYMBOL for tmio_mmc_host_alloc/free Ulf Hansson
2015-01-14 8:57 ` Kuninori Morimoto
2015-01-20 9:15 ` Ulf Hansson
2015-01-20 9:09 ` [PATCH 0/17 v2] tmio: mmc: header cleanup / sh_mobile_cleanup Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120093521.GE5767@x1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox