public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Chris Ball <chris@printf.net>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Boris BREZILLON <boris.brezillon@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Marcin Wojtas <mw@semihalf.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] mmc: sdhci-pxav3: Fix Armada 38x controller's caps according to erratum ERR-7878951
Date: Fri, 23 Jan 2015 11:03:03 +0000	[thread overview]
Message-ID: <20150123110303.GD23493@leverpostej> (raw)
In-Reply-To: <1422010594-1735-3-git-send-email-gregory.clement@free-electrons.com>

[...]

> +	/*
> +	 * According to erratum 'ERR-7878951' Armada 38x SDHCI
> +	 * controller has different capabilities than the ones shown
> +	 * in its registers
> +	 */
> +	host->caps = sdhci_readl(host, SDHCI_CAPABILITIES);
> +	if (of_get_property(np, "no-1-8-v", NULL)) {

Please use of_property_read_bool(np, "no-1-8-v")

> +		host->caps &= ~SDHCI_CAN_VDD_180;
> +		host->mmc->caps &= ~MMC_CAP_1_8V_DDR;

Is SDHCI_CAN_VDD_330 always set elsewhere in this case?

> +	} else
> +		host->caps &= ~SDHCI_CAN_VDD_330;

If one branch in an if-else pair is braced, both sides should be (as
Documentation/CodingStyle says). Please brace the else case.

Thanks,
Mark.

  reply	other threads:[~2015-01-23 11:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 10:56 [PATCH v2 0/7] Fixes and improvements for SDHCI on Armada 38x Gregory CLEMENT
     [not found] ` <1422010594-1735-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-01-23 10:56   ` [PATCH v2 1/7] mmc: sdhci-pxav3: Fix SDR50 and DDR50 capabilities for the Armada 38x flavor Gregory CLEMENT
2015-01-28 20:36     ` Ulf Hansson
2015-01-29  8:31       ` Gregory CLEMENT
2015-01-29  9:31         ` Ulf Hansson
2015-01-29  9:42           ` Gregory CLEMENT
     [not found]             ` <54CA006F.8060108-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-01-29 10:01               ` Ulf Hansson
2015-01-23 10:56   ` [PATCH v2 2/7] mmc: sdhci-pxav3: Fix Armada 38x controller's caps according to erratum ERR-7878951 Gregory CLEMENT
2015-01-23 11:03     ` Mark Rutland [this message]
2015-01-23 11:12       ` Marcin Wojtas
2015-01-23 11:33     ` Marcin Wojtas
2015-01-23 14:18       ` Gregory CLEMENT
2015-01-23 10:56   ` [PATCH v2 4/7] mmc: sdhci-pxav3: Modify clock settings for the SDR50 and DDR50 modes Gregory CLEMENT
2015-01-23 10:56   ` [PATCH v2 5/7] ARM: mvebu: Use macros for interrupt flags on Armada 38x sdhci node Gregory CLEMENT
2015-01-23 10:56   ` [PATCH v2 7/7] ARM: mvebu: Add Device Tree description of SDHCI for Armada 388 RD Gregory CLEMENT
2015-01-23 10:56 ` [PATCH v2 3/7] mmc: sdhci-pxav3: Extend binding with SDIO3 conf reg for the Armada 38x Gregory CLEMENT
2015-01-23 10:56 ` [PATCH v2 6/7] ARM: mvebu: Update the SDHCI node on " Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150123110303.GD23493@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=alior@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=boris.brezillon@free-electrons.com \
    --cc=chris@printf.net \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox