From: Greg KH <greg@kroah.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Cc: stable@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Tyler Baker <tyler.baker@linaro.org>
Subject: Re: [PATCH] mmc: sdhci: Don't signal the sdio irq if it's not setup
Date: Sun, 25 Jan 2015 09:45:16 -0800 [thread overview]
Message-ID: <20150125174516.GC6467@kroah.com> (raw)
In-Reply-To: <1421705229-20260-1-git-send-email-sjoerd.simons@collabora.co.uk>
On Mon, Jan 19, 2015 at 11:07:09PM +0100, Sjoerd Simons wrote:
> With 3.14.29 (and older kernels) some of my I.mx6 Sabrelite boards were
> crashing with the following oops:
>
> sdhci: Secure Digital Host Controller Interface driver
> sdhci: Copyright(c) Pierre Ossman
> sdhci-pltfm: SDHCI platform and OF driver helper
> sdhci-esdhc-imx 2198000.usdhc: could not get ultra high speed state, work on normal mode
> mmc0: no vqmmc regulator found
> mmc0: SDHCI controller on 2198000.usdhc [2198000.usdhc] using ADMA
> Unable to handle kernel NULL pointer dereference at virtual address 00000000
> pgd = c0004000
> [00000000] *pgd=00000000
> Internal error: Oops: 5 [#1] SMP ARM
> Modules linked in:
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.14.29 #1
> task: c08a7120 ti: c089c000 task.ti: c089c000
> PC is at wake_up_process+0x8/0x40
> LR is at sdhci_irq+0x748/0x9c4
>
> Full boot log can be found at:
> http://storage.kernelci.org/stable/v3.14.29/arm-multi_v7_defconfig/lab-collabora/boot-imx6q-sabrelite.html
>
> This happens if the sdhci interrupt status contains SDHCI_INT_CARD_INT,
> while the sdio irq was never setup. This patch fixes that in a minimal
> way by checking if the sdio irq was setup.
>
> In more recent kernels this bug went away due to refactoring done by
> Russel King. So an alternative (potentially better?) fix for this patch
> is to cherrypick the following patches from a recent kernel:
>
> 18258f7239a6 - genirq: Provide synchronize_hardirq()
> bf3b5ec66bd0 - mmc: sdio_irq: rework sdio irq handling
> 41005003bcaf - mmc: sdhci: clean up interrupt handling
> 781e989cf593 - mmc: sdhci: convert to new SDIO IRQ handling
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I don't understand, either take 4 patches, or this single-line patches?
And what kernel version(s) do you want this applied to?
confused,
greg k-h
next prev parent reply other threads:[~2015-01-25 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 22:07 [PATCH] mmc: sdhci: Don't signal the sdio irq if it's not setup Sjoerd Simons
2015-01-25 17:45 ` Greg KH [this message]
2015-01-25 17:54 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150125174516.GC6467@kroah.com \
--to=greg@kroah.com \
--cc=chris@printf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sjoerd.simons@collabora.co.uk \
--cc=stable@vger.kernel.org \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox