* [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning
@ 2015-02-26 20:37 Dan Carpenter
2015-02-27 7:14 ` Dong Aisheng
2015-03-05 13:48 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-26 20:37 UTC (permalink / raw)
To: Chris Ball, Aisheng Dong
Cc: Ulf Hansson, Russell King, Shawn Guo, Dirk Behme,
Rafael J. Wysocki, linux-mmc, kernel-janitors
Static checkers suggest that probably we intended to put curly braces
around the writel() to make it part of the else path. But, I think
actually the indenting is off and the code works fine as is.
The stray tab was introduced in 0322191e6298 ('mmc: sdhci-esdhc-imx: add
sd3.0 SDR clock tuning support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 10ef824..9cce5cf 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -416,7 +416,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
new_val |= ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
else
new_val &= ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
- writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
+ writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
return;
case SDHCI_HOST_CONTROL2:
new_val = readl(host->ioaddr + ESDHC_VENDOR_SPEC);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning
2015-02-26 20:37 [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning Dan Carpenter
@ 2015-02-27 7:14 ` Dong Aisheng
2015-03-05 13:48 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Dong Aisheng @ 2015-02-27 7:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chris Ball, Ulf Hansson, Russell King, Shawn Guo, Dirk Behme,
Rafael J. Wysocki, linux-mmc, kernel-janitors
On Thu, Feb 26, 2015 at 11:37:55PM +0300, Dan Carpenter wrote:
> Static checkers suggest that probably we intended to put curly braces
> around the writel() to make it part of the else path. But, I think
> actually the indenting is off and the code works fine as is.
>
> The stray tab was introduced in 0322191e6298 ('mmc: sdhci-esdhc-imx: add
> sd3.0 SDR clock tuning support')
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Yes, that's a mistake.
Thanks for the finding.
Acked-by: Dong Aisheng <b29396@freescale.com>
Regards
Dong Aisheng
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 10ef824..9cce5cf 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -416,7 +416,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
> new_val |= ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
> else
> new_val &= ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
> - writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
> + writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
> return;
> case SDHCI_HOST_CONTROL2:
> new_val = readl(host->ioaddr + ESDHC_VENDOR_SPEC);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning
2015-02-26 20:37 [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning Dan Carpenter
2015-02-27 7:14 ` Dong Aisheng
@ 2015-03-05 13:48 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-03-05 13:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chris Ball, Aisheng Dong, Russell King, Shawn Guo, Dirk Behme,
Rafael J. Wysocki, linux-mmc, kernel-janitors
On 26 February 2015 at 21:37, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Static checkers suggest that probably we intended to put curly braces
> around the writel() to make it part of the else path. But, I think
> actually the indenting is off and the code works fine as is.
>
> The stray tab was introduced in 0322191e6298 ('mmc: sdhci-esdhc-imx: add
> sd3.0 SDR clock tuning support')
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
Kind regards
Uffe
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 10ef824..9cce5cf 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -416,7 +416,7 @@ static void esdhc_writew_le(struct sdhci_host *host, u16 val, int reg)
> new_val |= ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
> else
> new_val &= ~ESDHC_VENDOR_SPEC_FRC_SDCLK_ON;
> - writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
> + writel(new_val, host->ioaddr + ESDHC_VENDOR_SPEC);
> return;
> case SDHCI_HOST_CONTROL2:
> new_val = readl(host->ioaddr + ESDHC_VENDOR_SPEC);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-05 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-26 20:37 [patch] mmc: sdhci-esdhc-imx: silence a false curly braces warning Dan Carpenter
2015-02-27 7:14 ` Dong Aisheng
2015-03-05 13:48 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox