From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
linux-arm-kernel@lists.infradead.org,
Ludovic Desroches <ludovic.desroches@atmel.com>,
Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
Date: Tue, 24 Mar 2015 15:08:47 +0100 [thread overview]
Message-ID: <20150324140847.GC16642@odux.rfo.atmel.com> (raw)
In-Reply-To: <1426693992-31163-13-git-send-email-ben.dooks@codethink.co.uk>
On Wed, Mar 18, 2015 at 03:53:11PM +0000, Ben Dooks wrote:
> Change the __raw IO functions to endian agnostic relaxed ones to allow
> the driver to function on big endian ARM systems.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> --
> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
> CC: Chris Ball <chris@printf.net>
> CC: Ulf Hansson <ulf.hansson@linaro.org>
> CC: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
> index c97001e..711bb53 100644
> --- a/drivers/mmc/host/atmel-mci-regs.h
> +++ b/drivers/mmc/host/atmel-mci-regs.h
> @@ -135,10 +135,17 @@
> #define ATMCI_REGS_SIZE 0x100
>
> /* Register access macros */
> -#define atmci_readl(port,reg) \
> +#ifdef CONFIG_AVR32
> +#define atmci_readl(port,reg) \
> __raw_readl((port)->regs + reg)
> #define atmci_writel(port,reg,value) \
> __raw_writel((value), (port)->regs + reg)
> +#else
> +#define atmci_readl(port,reg) \
> + readl_relaxed((port)->regs + reg)
> +#define atmci_writel(port,reg,value) \
> + writel_relaxed((value), (port)->regs + reg)
> +#endif
>
> /* On AVR chips the Peripheral DMA Controller is not connected to MCI. */
> #ifdef CONFIG_AVR32
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-03-24 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk>
2015-03-18 15:53 ` [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO Ben Dooks
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
2015-03-24 12:53 ` Ben Dooks
2015-03-25 6:14 ` Hans-Christian Egtvedt
2015-03-24 14:08 ` Ludovic Desroches [this message]
2015-03-25 8:52 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324140847.GC16642@odux.rfo.atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=ben.dooks@codethink.co.uk \
--cc=chris@printf.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox