Re: [PATCH RESEND v7 2/2] mmc: host: sdhci: Add support to disable SDR104/SDR50/DDR50 based on capability register 0.

Suman Tripathi
2015-06-01T08:08:47Z

[-- Attachment #1.1: Type: text/plain, Size: 1620 bytes --]

Hi Aisheng,

On Wed, May 27, 2015 at 7:46 PM, Suman Tripathi <stripathi@apm.com> wrote:

>
>
> On Tue, May 26, 2015 at 6:06 PM, Ulf Hansson <ulf.hansson@linaro.org>
> wrote:
>
>> On 21 May 2015 at 10:43, Suman Tripathi <stripathi@apm.com> wrote:
>> > The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk.
>> > This patch adds the support to disable SDR104/SDR50/DDR50 based on
>> > reading the capability register 0.
>> >
>> > Signed-off-by: Suman Tripathi <stripathi@apm.com>
>> > ---
>> > ---
>> > drivers/mmc/host/sdhci.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
>> > index 58c1770..a3d9b8a 100644
>> > --- a/drivers/mmc/host/sdhci.c
>> > +++ b/drivers/mmc/host/sdhci.c
>> > @@ -3118,7 +3118,8 @@ int sdhci_add_host(struct sdhci_host *host)
>> > }
>> > }
>> >
>> > - if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V)
>> > + if (host->quirks2 & SDHCI_QUIRK2_NO_1_8_V ||
>> > + !(caps[0] & SDHCI_CAN_VDD_180))
>> > caps[1] &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50
>> |
>> > SDHCI_SUPPORT_DDR50);
>> >
>> > --
>> > 1.8.2.1
>> >
>>
>> I have no problem with this patch, except that it would be nice to get
>> a few "tested by" to make sure it doesn't break UHS support for some
>> SoCs.
>>
>> Kind regards
>> Uffe
>>
>
> Can anyone test this in some other SoC ? Appreciate your help ..
>
> Can you test this patch on imx SoC ?

>
> --
> Thanks,
> with regards,
> Suman Tripathi
>

--
Thanks,
with regards,
Suman Tripathi

[-- Attachment #1.2: Type: text/html, Size: 3002 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org