Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request

Wolfram Sang
2015-06-15T16:34:35Z

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

Hi,

> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
> */
> if (IS_ERR_OR_NULL(mrq)
> || time_is_after_jiffies(host->last_req_ts +
> - msecs_to_jiffies(2000))) {
> + msecs_to_jiffies(5000))) {
> spin_unlock_irqrestore(&host->lock, flags);
> return;
> }
> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
> ret = tmio_mmc_start_command(host, mrq->cmd);
> if (!ret) {
> schedule_delayed_work(&host->delayed_reset_work,
> - msecs_to_jiffies(2000));
> + msecs_to_jiffies(5000));

What about using a define here since the same kind of magic value is
used in two different places?

Kind regards,

Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]