From: Ludovic Desroches <ludovic.desroches@atmel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ludovic Desroches <ludovic.desroches@atmel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: sdhci-of-at91: remove a line of dead code
Date: Thu, 17 Sep 2015 08:46:22 +0200 [thread overview]
Message-ID: <20150917064622.GS32379@odux.rfo.atmel.com> (raw)
In-Reply-To: <20150916061949.GA21542@mwanda>
On Wed, Sep 16, 2015 at 09:19:49AM +0300, Dan Carpenter wrote:
> The goto is correct and the unreachable "return -EINVAL" should be
> removed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Of course
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index d155664..d3df786 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -110,7 +110,6 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> if (ret < 0) {
> dev_err(&pdev->dev, "failed to set gck");
> goto hclock_disable_unprepare;
> - return -EINVAL;
> }
> /*
> * We need to check if we have the requested rate for gck because in
next prev parent reply other threads:[~2015-09-17 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 6:19 [patch] mmc: sdhci-of-at91: remove a line of dead code Dan Carpenter
2015-09-17 6:46 ` Ludovic Desroches [this message]
2015-09-17 8:49 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917064622.GS32379@odux.rfo.atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox