From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, sebastian.hesselbarth@gmail.com,
jason@lakedaemon.net, thomas.petazzoni@free-electrons.com,
gregory.clement@free-electrons.com, nadavh@marvell.com,
alior@marvell.com, tawfik@marvell.com, jaz@semihalf.com
Subject: Re: [PATCH 6/8] ARM: mvebu: enable SDHCI card detection using DAT3 pin on A388-GP
Date: Tue, 6 Oct 2015 05:31:31 +0200 [thread overview]
Message-ID: <20151006033131.GA24230@lunn.ch> (raw)
In-Reply-To: <1444094562-31165-7-git-send-email-mw@semihalf.com>
On Tue, Oct 06, 2015 at 03:22:40AM +0200, Marcin Wojtas wrote:
> The newest revisions of A388-GP (v1.5 and higher) support only
> DAT3-based card detection, which is enabled by this commit. Hitherto
> revisions, without such modification, will be impacted with a broken
> card detection - in order to operate the cards have to be present
> during kernel boot.
Humm. Is this acceptable, breaking old boards?
I would say at minimum, there should be a big fat comment at the top
of armada-388-gp.dts explaining that this DTS file is broken on
v0.0-v1.4.
Or we have two .dts files for the 388-gp file, and a dtsi file.
Andrew
next prev parent reply other threads:[~2015-10-06 3:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 1:22 [PATCH 0/8] Armada 38x SDHCI driver improvements Marcin Wojtas
2015-10-06 1:22 ` [PATCH 1/8] mmc: sdhci-pxav3: remove broken clock base quirk for Armada 38x sdhci driver Marcin Wojtas
2015-10-06 14:43 ` Gregory CLEMENT
2015-10-08 17:35 ` Ulf Hansson
2015-10-06 1:22 ` [PATCH 2/8] mmc: sdhci-pxav3: disable clock inversion for HS MMC cards Marcin Wojtas
2015-10-06 14:44 ` Gregory CLEMENT
2015-10-08 17:35 ` Ulf Hansson
2015-10-06 1:22 ` [PATCH 3/8] mmc: sdhci-pxav3: fix error handling of armada_38x_quirks Marcin Wojtas
2015-10-06 14:47 ` Gregory CLEMENT
2015-10-08 17:35 ` Ulf Hansson
2015-10-09 0:49 ` Marcin Wojtas
2015-10-06 1:22 ` [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas
2015-10-06 14:51 ` Gregory CLEMENT
2015-10-06 15:08 ` Marcin Wojtas
2015-10-09 1:09 ` Jisheng Zhang
2015-10-09 9:48 ` Marcin Wojtas
2015-10-06 1:22 ` [PATCH 5/8] mmc: sdhci-pxav3: enable usage of DAT3 pin as HW card detect Marcin Wojtas
2015-10-06 1:22 ` [PATCH 6/8] ARM: mvebu: enable SDHCI card detection using DAT3 pin on A388-GP Marcin Wojtas
2015-10-06 3:31 ` Andrew Lunn [this message]
2015-10-06 7:02 ` Marcin Wojtas
2015-10-06 14:45 ` Andrew Lunn
2015-10-06 15:05 ` Marcin Wojtas
2015-10-06 16:23 ` Andrew Lunn
2015-10-06 15:05 ` Gregory CLEMENT
2015-10-06 15:35 ` Marcin Wojtas
2015-10-06 16:20 ` Andrew Lunn
2015-10-06 1:22 ` [PATCH 7/8] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas
2015-10-06 1:22 ` [PATCH 8/8] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas
2015-10-06 14:43 ` [PATCH 0/8] Armada 38x SDHCI driver improvements Gregory CLEMENT
2015-10-06 15:48 ` Marcin Wojtas
2015-10-08 13:21 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006033131.GA24230@lunn.ch \
--to=andrew@lunn.ch \
--cc=alior@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).