linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver
@ 2015-09-17 21:50 Luis de Bethencourt
  2015-10-06  8:09 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-17 21:50 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jarkko Lavinen, Ulf Hansson, linux-omap, linux-mmc

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/mmc/host/omap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index b763b11..b9958a1 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1490,6 +1490,7 @@ static const struct of_device_id mmc_omap_match[] = {
 	{ .compatible = "ti,omap2420-mmc", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, mmc_omap_match);
 #endif
 
 static struct platform_driver mmc_omap_driver = {
-- 
2.4.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver
  2015-09-17 21:50 [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver Luis de Bethencourt
@ 2015-10-06  8:09 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2015-10-06  8:09 UTC (permalink / raw)
  To: Luis de Bethencourt
  Cc: linux-kernel, Jarkko Lavinen, Ulf Hansson, linux-omap, linux-mmc

* Luis de Bethencourt <luis@debethencourt.com> [150917 14:54]:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Looks OK to me, this would be mostly for n8x0:

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/mmc/host/omap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index b763b11..b9958a1 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1490,6 +1490,7 @@ static const struct of_device_id mmc_omap_match[] = {
>  	{ .compatible = "ti,omap2420-mmc", },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, mmc_omap_match);
>  #endif
>  
>  static struct platform_driver mmc_omap_driver = {
> -- 
> 2.4.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-06  8:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-17 21:50 [PATCH 3/3] mmc: omap: Fix module autoload for OF platform driver Luis de Bethencourt
2015-10-06  8:09 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).