* [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST
@ 2015-10-10 16:08 Luis de Bethencourt
2015-10-13 7:12 ` Jean Delvare
2015-10-16 8:25 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-10-10 16:08 UTC (permalink / raw)
To: linux-kernel
Cc: ulf.hansson, jdelvare, Weijun.Yang, sbranden, t.takinishi, sboyd,
alim.akhtar, ludovic.desroches, vincent.yang.fujitsu,
chaotian.jing, linux, yangbo.lu, haokexin, linux-mmc, javier,
Luis de Bethencourt
The driver depends on GOLDFISH but there isn't a build dependency
so it's a good idea to allow the driver to always be built when the
COMPILE_TEST option is enabled.
That way, the driver can be built with a config generated by make
allyesconfig and check if a patch would break the build.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 12b274a..56f5b14 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -473,7 +473,7 @@ config MMC_DAVINCI
config MMC_GOLDFISH
tristate "goldfish qemu Multimedia Card Interface support"
- depends on GOLDFISH
+ depends on GOLDFISH || COMPILE_TEST
help
This selects the Goldfish Multimedia card Interface emulation
found on the Goldfish Android virtual device emulation.
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST
2015-10-10 16:08 [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Luis de Bethencourt
@ 2015-10-13 7:12 ` Jean Delvare
2015-10-16 8:25 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2015-10-13 7:12 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, ulf.hansson, Weijun.Yang, sbranden, t.takinishi,
sboyd, alim.akhtar, ludovic.desroches, vincent.yang.fujitsu,
chaotian.jing, linux, yangbo.lu, haokexin, linux-mmc, javier
On Sat, 10 Oct 2015 17:08:32 +0100, Luis de Bethencourt wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to always be built when the
> COMPILE_TEST option is enabled.
>
> That way, the driver can be built with a config generated by make
> allyesconfig and check if a patch would break the build.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 12b274a..56f5b14 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,7 +473,7 @@ config MMC_DAVINCI
>
> config MMC_GOLDFISH
> tristate "goldfish qemu Multimedia Card Interface support"
> - depends on GOLDFISH
> + depends on GOLDFISH || COMPILE_TEST
> help
> This selects the Goldfish Multimedia card Interface emulation
> found on the Goldfish Android virtual device emulation.
Looks good.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST
2015-10-10 16:08 [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Luis de Bethencourt
2015-10-13 7:12 ` Jean Delvare
@ 2015-10-16 8:25 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2015-10-16 8:25 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel@vger.kernel.org, Jean Delvare, Weijun Yang,
Scott Branden, Tetsuya Takinishi, Stephen Boyd, ALIM AKHTAR,
Ludovic Desroches, Vincent Yang, Chaotian Jing, Ondrej Zary,
Yangbo Lu, Kevin Hao, linux-mmc, Javier Martinez Canillas
On 10 October 2015 at 18:08, Luis de Bethencourt <luisbg@osg.samsung.com> wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to always be built when the
> COMPILE_TEST option is enabled.
>
> That way, the driver can be built with a config generated by make
> allyesconfig and check if a patch would break the build.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 12b274a..56f5b14 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,7 +473,7 @@ config MMC_DAVINCI
>
> config MMC_GOLDFISH
> tristate "goldfish qemu Multimedia Card Interface support"
> - depends on GOLDFISH
> + depends on GOLDFISH || COMPILE_TEST
> help
> This selects the Goldfish Multimedia card Interface emulation
> found on the Goldfish Android virtual device emulation.
> --
> 2.5.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-16 8:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-10 16:08 [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Luis de Bethencourt
2015-10-13 7:12 ` Jean Delvare
2015-10-16 8:25 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox