From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Date: Tue, 13 Oct 2015 09:12:17 +0200 Message-ID: <20151013091217.0cc0632d@endymion.delvare> References: <1444493312-1592-1-git-send-email-luisbg@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:49621 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752048AbbJMHMY (ORCPT ); Tue, 13 Oct 2015 03:12:24 -0400 In-Reply-To: <1444493312-1592-1-git-send-email-luisbg@osg.samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Luis de Bethencourt Cc: linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, Weijun.Yang@csr.com, sbranden@broadcom.com, t.takinishi@jp.fujitsu.com, sboyd@codeaurora.org, alim.akhtar@samsung.com, ludovic.desroches@atmel.com, vincent.yang.fujitsu@gmail.com, chaotian.jing@mediatek.com, linux@rainbow-software.org, yangbo.lu@freescale.com, haokexin@gmail.com, linux-mmc@vger.kernel.org, javier@osg.samsung.com On Sat, 10 Oct 2015 17:08:32 +0100, Luis de Bethencourt wrote: > The driver depends on GOLDFISH but there isn't a build dependency > so it's a good idea to allow the driver to always be built when the > COMPILE_TEST option is enabled. > > That way, the driver can be built with a config generated by make > allyesconfig and check if a patch would break the build. > > Signed-off-by: Luis de Bethencourt > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 12b274a..56f5b14 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -473,7 +473,7 @@ config MMC_DAVINCI > > config MMC_GOLDFISH > tristate "goldfish qemu Multimedia Card Interface support" > - depends on GOLDFISH > + depends on GOLDFISH || COMPILE_TEST > help > This selects the Goldfish Multimedia card Interface emulation > found on the Goldfish Android virtual device emulation. Looks good. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support