From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic Desroches Subject: Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power Date: Tue, 24 Nov 2015 10:23:41 +0100 Message-ID: <20151124092341.GA2228@odux.rfo.atmel.com> References: <1446825570-30029-1-git-send-email-ludovic.desroches@atmel.com> <1446825570-30029-2-git-send-email-ludovic.desroches@atmel.com> <20151109132305.GC15706@odux.rfo.atmel.com> <20151109144030.GD15706@odux.rfo.atmel.com> <20151109163026.GE15706@odux.rfo.atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20151109163026.GE15706-FuRPzXQv2LUWBfJKYY8PcdBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ulf Hansson , Nicolas Ferre , Alexandre Belloni , linux-mmc , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jean-Christophe Plagniol-Villard , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-mmc@vger.kernel.org Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is this discussion because of two things: > - Fixing something I consider as a bug: when I have a VMMC, only > setting/clearing bit 0. Our controller strictly obeys to the spec and > check the 'SD Bus Voltage Select' field. Since we put a reserved value > (000), the Power On is not performed. > - I was trying to get help to understand what is this 'SD Bus Voltage'. > For our controller and sdhci_set_power(), it seems to stand for VMMC. > For me, everything concerning bus voltage is related to VQMMC, so I was > disappointed. Do you plan to take the patch for VMMC? If yes, I will send a new patch for the device tree (I'll only add vmmc, not vqmmc as discussed); if not, forget these two patches. Regards Ludovic -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html