[PATCH] mmc: tegra: don't enable UHS modes on Tegra210

[PATCH] mmc: tegra: don't enable UHS modes on Tegra210

[Lucas Stach]

Tegra210 needs a different tuning sequence than Tegra30+. Disable
UHS modes until support for this is properly added.

Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
---
Ulf,
this is a follow on patch to my Tegra UHS-I series. After reading the
Tegra210 TRM I realized that the currently implemented tuning sequence will
only work on Tegra30..Tegra124.  If you don't keep your tree stable you
might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
otherwise please pick this up as a fix on top.
---
 drivers/mmc/host/sdhci-tegra.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index b5abbe2..83c4bf7 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
 
 static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
 	.pdata = &sdhci_tegra210_pdata,
-	.nvquirks = NVQUIRK_ENABLE_SDR50 |
-		    NVQUIRK_ENABLE_DDR50 |
-		    NVQUIRK_ENABLE_SDR104,
 };
 
 static const struct of_device_id sdhci_tegra_dt_match[] = {
-- 
2.5.0

Re: [PATCH] mmc: tegra: don't enable UHS modes on Tegra210

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

On Wed, Dec 30, 2015 at 04:49:09PM +0100, Lucas Stach wrote:
> Tegra210 needs a different tuning sequence than Tegra30+. Disable
> UHS modes until support for this is properly added.
> 
> Signed-off-by: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
> ---
> Ulf,
> this is a follow on patch to my Tegra UHS-I series. After reading the
> Tegra210 TRM I realized that the currently implemented tuning sequence will
> only work on Tegra30..Tegra124.  If you don't keep your tree stable you
> might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
> otherwise please pick this up as a fix on top.
> ---
>  drivers/mmc/host/sdhci-tegra.c | 3 ---
>  1 file changed, 3 deletions(-)

Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] mmc: tegra: don't enable UHS modes on Tegra210

[Ulf Hansson]

On 30 December 2015 at 16:49, Lucas Stach <dev@lynxeye.de> wrote:
> Tegra210 needs a different tuning sequence than Tegra30+. Disable
> UHS modes until support for this is properly added.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> Ulf,
> this is a follow on patch to my Tegra UHS-I series. After reading the
> Tegra210 TRM I realized that the currently implemented tuning sequence will
> only work on Tegra30..Tegra124.  If you don't keep your tree stable you
> might want to squash this into [PATCH v2 4/5] mmc: tegra: enable UHS-I modes,
> otherwise please pick this up as a fix on top.

Thanks, I have squashed the change into patch4.

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-tegra.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index b5abbe2..83c4bf7 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -353,9 +353,6 @@ static const struct sdhci_pltfm_data sdhci_tegra210_pdata = {
>
>  static const struct sdhci_tegra_soc_data soc_data_tegra210 = {
>         .pdata = &sdhci_tegra210_pdata,
> -       .nvquirks = NVQUIRK_ENABLE_SDR50 |
> -                   NVQUIRK_ENABLE_DDR50 |
> -                   NVQUIRK_ENABLE_SDR104,
>  };
>
>  static const struct of_device_id sdhci_tegra_dt_match[] = {
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html