From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH v3 00/12] mmc: use sdhci_pltfm_init for private allocation and clean up Date: Mon, 25 Jan 2016 19:09:12 +0800 Message-ID: <20160125190912.001ee172@xhacker> References: <1452076303-1960-1-git-send-email-jszhang@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452076303-1960-1-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org, michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org, srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, maxime.coquelin-qxv4g6HH51o@public.gmane.org, patrice.chotard-qxv4g6HH51o@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-mmc@vger.kernel.org Dear All, On Wed, 6 Jan 2016 18:31:31 +0800 Jisheng Zhang wrote: > These patches are to complete the TODOs in Commit 0e748234293f ("mmc: > sdhci: Add size for caller in init+register"), I.E: > > - todo: migrate clients to using allocation this way > - todo: remove priv variable once migration is complete What do you think about this series? Do I need to rebase on 4.5-rc1 then send a v4? Any suggestions are appreciated. Thanks in advance, Jisheng > > Since v2: > - based on mmc next tree and remove all priv usage introduced in newly > commits in this tree > - don't break two lines if sdhci_pltfm_init() call could be put into > one line. Thank Ludovic Desroches. > > Since v1: > - add new patch03 to factorise sdhci_msm_pdata outisde of sdhci_msm_host. > This is to fix drivers/mmc/host/sdhci-msm.c:440:32: warning: 'msm_host' > is used uninitialized in this function [-Wuninitialized] > - Add Arnd's Ack for all patches except patch3 which is new in v2 > > > Jisheng Zhang (12): > mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation > mmc: sdhci-esdhc-imx: use sdhci_pltfm_init for private allocation > mmc: sdhci-msm: factorise sdhci_msm_pdata outisde of sdhci_msm_host > mmc: sdhci-msm: use sdhci_pltfm_init for private allocation > mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation > mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation > mmc: sdhci-of-esdhc: use sdhci_pltfm_init for private allocation > mmc: sdhci-pxav3: use sdhci_pltfm_init for private allocation > mmc: sdhci-st: use sdhci_pltfm_init for private allocation > mmc: sdhci-tegra: use sdhci_pltfm_init for private allocation > mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv > mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host > > drivers/mmc/host/sdhci-bcm2835.c | 14 +++----------- > drivers/mmc/host/sdhci-esdhc-imx.c | 38 +++++++++++++++++--------------------- > drivers/mmc/host/sdhci-msm.c | 23 ++++++++++------------- > drivers/mmc/host/sdhci-of-arasan.c | 25 ++++++++++--------------- > drivers/mmc/host/sdhci-of-at91.c | 24 +++++++++--------------- > drivers/mmc/host/sdhci-of-esdhc.c | 19 +++++++++---------- > drivers/mmc/host/sdhci-pltfm.h | 1 - > drivers/mmc/host/sdhci-pxav2.c | 1 - > drivers/mmc/host/sdhci-pxav3.c | 20 ++++++++------------ > drivers/mmc/host/sdhci-st.c | 35 +++++++++++++++++------------------ > drivers/mmc/host/sdhci-tegra.c | 21 +++++++-------------- > 11 files changed, 90 insertions(+), 131 deletions(-) >