Re: [PATCH v3 07/25] mmc: sdhci: command response CRC error handling

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3376 bytes --]

Hi Russell,

[auto build test WARNING on ulf.hansson-mmc/next]
[also build test WARNING on v4.5-rc1 next-20160125]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Russell-King/mmc-core-shut-up-voltage-ranges-unspecified-pr_info/20160126-214738
base:   https://git.linaro.org/people/ulf.hansson/mmc next
config: x86_64-randconfig-x018-01260845 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from include/linux/delay.h:10,
                    from drivers/mmc/host/sdhci.c:16:
   drivers/mmc/host/sdhci.c: In function 'sdhci_cmd_irq':
   drivers/mmc/host/sdhci.c:2344:15: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
          intmask & (SDHCI_INT_CRC | SDHCI_INT_TIMEOUT) ==
                  ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/mmc/host/sdhci.c:2343:3: note: in expansion of macro 'if'
      if (host->cmd->data &&
      ^
   drivers/mmc/host/sdhci.c:2344:15: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
          intmask & (SDHCI_INT_CRC | SDHCI_INT_TIMEOUT) ==
                  ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> drivers/mmc/host/sdhci.c:2343:3: note: in expansion of macro 'if'
      if (host->cmd->data &&
      ^
   drivers/mmc/host/sdhci.c:2344:15: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
          intmask & (SDHCI_INT_CRC | SDHCI_INT_TIMEOUT) ==
                  ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> drivers/mmc/host/sdhci.c:2343:3: note: in expansion of macro 'if'
      if (host->cmd->data &&
      ^

vim +/if +2343 drivers/mmc/host/sdhci.c

  2327			       SDHCI_INT_END_BIT | SDHCI_INT_INDEX)) {
  2328			if (intmask & SDHCI_INT_TIMEOUT)
  2329				host->cmd->error = -ETIMEDOUT;
  2330			else
  2331				host->cmd->error = -EILSEQ;
  2332	
  2333			/*
  2334			 * If this command initiates a data phase and a response
  2335			 * CRC error is signalled, the card can start transferring
  2336			 * data - the card may have received the command without
  2337			 * error.  We must not terminate the mmc_request early.
  2338			 *
  2339			 * If the card did not receive the command or returned an
  2340			 * error which prevented it sending data, the data phase
  2341			 * will time out.
  2342			 */
> 2343			if (host->cmd->data &&
  2344			    intmask & (SDHCI_INT_CRC | SDHCI_INT_TIMEOUT) ==
  2345			     SDHCI_INT_CRC) {
  2346				host->cmd = NULL;
  2347				return;
  2348			}
  2349	
  2350			tasklet_schedule(&host->finish_tasklet);
  2351			return;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 25668 bytes --]