From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic Desroches Subject: Re: [PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path Date: Wed, 27 Jan 2016 17:17:54 +0100 Message-ID: <20160127161754.GE6149@odux.rfo.atmel.com> References: <1453804954-3490-1-git-send-email-jszhang@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1453804954-3490-1-git-send-email-jszhang@marvell.com> Sender: linux-kernel-owner@vger.kernel.org To: Jisheng Zhang Cc: ludovic.desroches@atmel.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org On Tue, Jan 26, 2016 at 06:42:34PM +0800, Jisheng Zhang wrote: > The device power usage counter is increased by pm_runtime_get_noresume > but isn't decreased in err_add_host error path. > > Fix this issue by calling pm_runtime_put_noidle() in the error path to > restore the device's power usage counter. > Well spotted, thanks. > Signed-off-by: Jisheng Zhang Acked-by: Ludovic Desroches > Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support) > --- > drivers/mmc/host/sdhci-of-at91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 7db7163..3bf6f31 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -210,7 +210,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > > pm_runtime_disable: > pm_runtime_disable(&pdev->dev); > - pm_runtime_set_suspended(&pdev->dev); > + pm_runtime_put_noidle(&pdev->dev); > clocks_disable_unprepare: > clk_disable_unprepare(priv->gck); > clk_disable_unprepare(priv->mainck); > -- > 2.7.0 >