From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
linux-mmc@vger.kernel.org, Marcin Wojtas <mw@semihalf.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v3 09/25] mmc: sdhci: allocate alignment and DMA descriptor buffer together
Date: Wed, 27 Jan 2016 19:50:57 +0000 [thread overview]
Message-ID: <20160127195057.GH10826@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <56A88A81.8090505@intel.com>
On Wed, Jan 27, 2016 at 11:14:41AM +0200, Adrian Hunter wrote:
> On 26/01/16 15:39, Russell King wrote:
> > - } else if (host->adma_addr & (SDHCI_ADMA2_DESC_ALIGN - 1)) {
> > + } else if (dma & SDHCI_ADMA2_MASK) {
>
> The descriptor table has a bigger alignment requirement, so that should remain the check i.e.
>
> } else if ((dma + host->align_buffer_sz) & (SDHCI_ADMA2_DESC_ALIGN - 1)) {
No other comments?
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-01-27 19:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 13:38 [PATCH v3 00/25] MMC/SDHCI fixes Russell King - ARM Linux
2016-01-26 13:39 ` [PATCH v3 01/25] mmc: core: shut up "voltage-ranges unspecified" pr_info() Russell King
2016-01-26 13:39 ` [PATCH v3 02/25] mmc: core: improve mmc_of_parse_voltage() to return better status Russell King
2016-01-26 13:39 ` [PATCH v3 03/25] mmc: block: shut up "retrying because a re-tune was needed" message Russell King
2016-01-26 13:39 ` [PATCH v3 04/25] mmc: core: report tuning command execution failure reason Russell King
2016-01-26 13:39 ` [PATCH v3 05/25] mmc: sdhci: move initialisation of command error member Russell King
2016-01-26 13:39 ` [PATCH v3 06/25] mmc: sdhci: clean up command error handling Russell King
2016-01-26 13:39 ` [PATCH v3 07/25] mmc: sdhci: command response CRC " Russell King
2016-01-26 14:10 ` kbuild test robot
2016-01-26 14:11 ` kbuild test robot
2016-01-26 13:39 ` [PATCH v3 08/25] mmc: sdhci: avoid unnecessary mapping/unmapping of align buffer Russell King
2016-01-26 13:39 ` [PATCH v3 09/25] mmc: sdhci: allocate alignment and DMA descriptor buffer together Russell King
2016-01-27 9:14 ` Adrian Hunter
2016-01-27 19:50 ` Russell King - ARM Linux [this message]
2016-01-26 13:40 ` [PATCH v3 10/25] mmc: sdhci: clean up coding style in sdhci_adma_table_pre() Russell King
2016-01-26 13:40 ` [PATCH v3 11/25] mmc: sdhci: avoid walking SG list for writes Russell King
2016-01-26 13:40 ` [PATCH v3 12/25] mmc: sdhci: factor out common DMA cleanup in sdhci_finish_data() Russell King
2016-01-26 13:40 ` [PATCH v3 13/25] mmc: sdhci: move sdhci_pre_dma_transfer() Russell King
2016-01-26 13:40 ` [PATCH v3 14/25] mmc: sdhci: factor out sdhci_pre_dma_transfer() from sdhci_adma_table_pre() Russell King
2016-01-26 13:40 ` [PATCH v3 15/25] mmc: sdhci: pass the cookie into sdhci_pre_dma_transfer() Russell King
2016-01-26 13:40 ` [PATCH v3 16/25] mmc: sdhci: always unmap a mapped data transfer in sdhci_post_req() Russell King
2016-01-26 13:40 ` [PATCH v3 17/25] mmc: sdhci: clean up host cookie handling Russell King
2016-01-26 13:40 ` [PATCH v3 18/25] mmc: sdhci: plug DMA mapping leak on error Russell King
2016-01-26 13:40 ` [PATCH v3 19/25] mmc: sdhci-pxav3: fix higher speed mode capabilities Russell King
2016-01-26 13:40 ` [PATCH v3 20/25] mmc: sdhci: further fix for DMA unmapping in sdhci_post_req() Russell King
2016-01-26 13:40 ` [PATCH v3 21/25] mmc: sdhci: fix data timeout (part 1) Russell King
2016-01-26 13:41 ` [PATCH v3 22/25] mmc: sdhci: fix data timeout (part 2) Russell King
2016-01-26 13:41 ` [PATCH v3 23/25] mmc: sdhci: prepare DMA address/size quirk handling consolidation Russell King
2016-01-26 13:41 ` [PATCH v3 24/25] mmc: sdhci: consolidate the DMA/ADMA size/address quicks Russell King
2016-01-26 13:41 ` [PATCH v3 25/25] mmc: sdhci: further code simplication Russell King
2016-01-26 15:33 ` [PATCH v3 00/25] MMC/SDHCI fixes Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127195057.GH10826@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=adrian.hunter@intel.com \
--cc=gregory.clement@free-electrons.com \
--cc=kernel@pengutronix.de \
--cc=linux-mmc@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).