From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] Revert "mmc: block: don't use parameter prefix if built as module" Date: Thu, 11 Feb 2016 09:19:41 -0800 Message-ID: <20160211171941.GA29378@kroah.com> References: <1455206051-8633-1-git-send-email-ulf.hansson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41689 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbcBKRTn (ORCPT ); Thu, 11 Feb 2016 12:19:43 -0500 Content-Disposition: inline In-Reply-To: <1455206051-8633-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, John Stultz , Andy Shevchenko On Thu, Feb 11, 2016 at 04:54:11PM +0100, Ulf Hansson wrote: > This reverts commit 829b6962f7e3cfc06f7c5c26269fd47ad48cf503. > > Revert this change as it causes a sysfs path to change and therefore > introduces and ABI regression. More precisely Android's vold is not being > able to access /sys/module/mmcblk/parameters/perdev_minors any more, since > the path becomes changed to: "/sys/module/mmc_block/..." > > Fixes: 829b6962f7e3 ("mmc: block: don't use parameter prefix if built as > module") > Reported-by: John Stultz > Cc: Andy Shevchenko > Signed-off-by: Ulf Hansson Please also add a "cc: stable..." tag to the patch so it gets picked up in stable kernel releases. thanks, greg k-h