From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 3/7] spi: omap2-mcspi: Fix PM regression with deferred probe for pm_runtime_reinit Date: Thu, 11 Feb 2016 09:36:20 -0800 Message-ID: <20160211173620.GU19432@atomide.com> References: <1455145370-20301-1-git-send-email-tony@atomide.com> <1455145370-20301-4-git-send-email-tony@atomide.com> <20160211115128.GF13270@sirena.org.uk> <20160211150806.GS19432@atomide.com> <20160211155255.GA1953@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160211155255.GA1953-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alan Stern , Kevin Hilman , Nishanth Menon , "Rafael J . Wysocki" , Ulf Hansson , Tero Kristo , Greg Kroah-Hartman , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Peter Hurley , Wolfram Sang List-Id: linux-mmc@vger.kernel.org * Mark Brown [160211 07:54]: > On Thu, Feb 11, 2016 at 07:08:06AM -0800, Tony Lindgren wrote: > > * Mark Brown [160211 03:52]: > > > > Why, I'm not seeing any dependencies here? I'd also expect to be seeing > > > an awful lot more changes like this, this shouldn't be an OMAP thing - > > > do we need to fix the core API and then roll out the transition in a > > > different way? > > > Please feel free to pick up this one if you have other fixes > > lined up, nothing stopping that. > > I'll take it myself unless there is a strong reason to merge it as part > of another series. OK thanks! > > There will be likely more fixes like this to make drivers follow > > the PM runtime API documentation. These were just the initial > > ones that were obvious. > > This does sound like there's been a change in the interface compared to > what users are actually doing - is this an actual problem or is it just > a divergence from docs? It's an actual problem at least on omaps as the omap_device code is very picky about the hardware state. Depending how the PM runtime is implemented, it may be a problem for some other cases too. For non-omap cases, my guess is that it's mostly a divergence from the docs and non-critical. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html